Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert better default grids #6512

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Insert better default grids #6512

merged 7 commits into from
Oct 11, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Oct 10, 2024

Problem:

  1. When creating a grid layout from the inspector the default grid should be 2x2 with a 10px gap
  2. There should be an insert menu entry in the canvas toolbar for a 3x3 grid with a 10px gap
  3. There should be an entry for a grid in the floating component picker too

Fix:

Implement all of the above:

Kapture.2024-10-10.at.14.34.11.mp4

Note: the icon for the grid is the one used for the navigator, there should be a dedicated one with the right size (16x16) for the canvas toolbar as well.

Fixes #6511

@ruggi ruggi changed the title convert with 2x2 gap grid Insert better default grids Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Try me

Copy link

relativeci bot commented Oct 10, 2024

#14721 Bundle Size — 57.94MiB (~+0.01%).

0501054(current) vs 916e8b9 master#14701(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14721
     Baseline
#14701
Regression  Initial JS 40.94MiB(~+0.01%) 40.94MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 17.94% 17.91%
No change  Chunks 21 21
No change  Assets 23 23
No change  Modules 4145 4145
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.32% 27.32%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14721
     Baseline
#14701
Regression  JS 57.93MiB (~+0.01%) 57.93MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch feat/insert-grid-2x2-3x3Project dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi marked this pull request as ready for review October 10, 2024 12:42
@ruggi ruggi merged commit 6ec725c into master Oct 11, 2024
15 checks passed
@ruggi ruggi deleted the feat/insert-grid-2x2-3x3 branch October 11, 2024 10:42
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**

1. When creating a grid layout from the inspector the default grid
should be 2x2 with a 10px gap
2. There should be an insert menu entry in the canvas toolbar for a 3x3
grid with a 10px gap
3. There should be an entry for a grid in the floating component picker
too

**Fix:**

Implement all of the above:



https://github.com/user-attachments/assets/6214c47d-ae77-4735-b9ec-ab00198e4b90

Note: the icon for the grid is the one used for the navigator, there
should be a dedicated one with the right size (16x16) for the canvas
toolbar as well.

Fixes #6511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insert menu grid + 2x2 when converting
3 participants