-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert better default grids #6512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14721 Bundle Size — 57.94MiB (~+0.01%).0501054(current) vs 916e8b9 master#14701(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
Current #14721 |
Baseline #14701 |
|
---|---|---|
Initial JS | 40.94MiB (~+0.01% ) |
40.94MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 17.94% |
17.91% |
Chunks | 21 |
21 |
Assets | 23 |
23 |
Modules | 4145 |
4145 |
Duplicate Modules | 213 |
213 |
Duplicate Code | 27.32% |
27.32% |
Packages | 477 |
477 |
Duplicate Packages | 70 |
70 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #14721 |
Baseline #14701 |
|
---|---|---|
JS | 57.93MiB (~+0.01% ) |
57.93MiB |
HTML | 7.37KiB (-0.25% ) |
7.39KiB |
Bundle analysis report Branch feat/insert-grid-2x2-3x3 Project dashboard
Generated by RelativeCI Documentation Report issue
balazsbajorics
approved these changes
Oct 11, 2024
liady
approved these changes
Oct 11, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** 1. When creating a grid layout from the inspector the default grid should be 2x2 with a 10px gap 2. There should be an insert menu entry in the canvas toolbar for a 3x3 grid with a 10px gap 3. There should be an entry for a grid in the floating component picker too **Fix:** Implement all of the above: https://github.com/user-attachments/assets/6214c47d-ae77-4735-b9ec-ab00198e4b90 Note: the icon for the grid is the one used for the navigator, there should be a dedicated one with the right size (16x16) for the canvas toolbar as well. Fixes #6511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Fix:
Implement all of the above:
Kapture.2024-10-10.at.14.34.11.mp4
Note: the icon for the grid is the one used for the navigator, there should be a dedicated one with the right size (16x16) for the canvas toolbar as well.
Fixes #6511