Remove unnecessary custom require function boilerplate #6514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14778 Bundle Size — 57.94MiB (~-0.01%).0435e46(current) vs 916e8b9 master#14776(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14778 |
Baseline #14776 |
|
|---|---|---|
 Initial JS |
40.94MiB(~-0.01%) |
40.94MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
17.94% |
17.93% |
| Chunks |
21 |
21 |
| Assets |
23 |
23 |
| Modules |
4148 |
4148 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.32% |
27.32% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 2 improvements
| Current #14778 |
Baseline #14776 |
|
|---|---|---|
| JS |
57.93MiB (~-0.01%) |
57.93MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch fix/custom-require-minus-boilerp... Project dashboard
Generated by RelativeCI Documentation Report issue
…to fix/custom-require-minus-boilerplate
…to fix/custom-require-minus-boilerplate
bkrmendy
changed the title
bkrmendy
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
liady
Rheeseyb
approved these changes
Oct 15, 2024
liady
approved these changes
Oct 15, 2024
Rheeseyb
approved these changes
Oct 15, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Problem In multiple places there's unnecessary boilerplate code around creating the custom `require` function. ## Fix Remove the boilerplate code, since it's only necessary where we want to inject `ComponentRendererComponent`s or or collect data in `MutableUtopiaCtxRefData` ### Details - updated snapshot tests in the property control descriptions tests, which kept the file extension of the module key in a way that wasn't consistent with the rest of the tests - added a tests that makes sure that components in `RemixScene`s can be focused (an earlier iteration of this PR broke component focusing in `RemixScene`s) **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In multiple places there's unnecessary boilerplate code around creating the custom
requirefunction.Fix
Remove the boilerplate code, since it's only necessary where we want to inject
ComponentRendererComponents or or collect data inMutableUtopiaCtxRefDataDetails
RemixScenes can be focused (an earlier iteration of this PR broke component focusing inRemixScenes)Manual Tests:
I hereby swear that: