Paste grid cell as sibling #6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14723 Bundle Size — 57.95MiB (+0.02%).c170a70(current) vs 916e8b9 master#14701(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14723 |
Baseline #14701 |
|
|---|---|---|
 Initial JS |
40.95MiB(+0.03%) |
40.94MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.46% |
17.91% |
| Chunks |
21 |
21 |
| Assets |
23 |
23 |
| Modules |
4147(+0.05%) |
4145 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.31%(-0.04%) |
27.32% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14723 |
Baseline #14701 |
|
|---|---|---|
| JS |
57.94MiB (+0.02%) |
57.93MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/past-grid-cell Project dashboard
Generated by RelativeCI Documentation Report issue
balazsbajorics
approved these changes
Oct 10, 2024
liady
reviewed
Oct 11, 2024
| return null | ||
| } | ||
|
|
||
| const targetIsGridCell = MetadataUtils.isGridCell(metadata, selectedView) |
There was a problem hiding this comment.
just a small unrelated (non-blocking) naming nitpick - the element itself should probably be called "grid child" (since a "grid cell" is usually the actual cell and not the element being copied in this case)
There was a problem hiding this comment.
true, but we should also update the method name (isGridChild). We have a bunch of naming cleanup to do, (e.g. tracks vs dimensions). If that's ok I'll leave it to clean up in the future, but rename that constant now.
liady
approved these changes
Oct 11, 2024
Rheeseyb
approved these changes
Oct 11, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Copy-pasting a grid cell ends up pasting it inside the selected element instead of next to it. **Fix:** If the copied element is a grid cell and the target is another grid cell, paste next to it. | Before | After | |------------|-------------| |  |  | Fixes #6515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Copy-pasting a grid cell ends up pasting it inside the selected element instead of next to it.
Fix:
If the copied element is a grid cell and the target is another grid cell, paste next to it.
Fixes #6515