Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We use grid-rearrange-move code after reparenting into a grid to position the element into the target cell.
However,
reorder
mode of grid-rearrange-move is never activated, so we set explicit gridRow/gridColumn props even when unnecessary.Fix:
runGridRearrangeMove
callednewPathAfterReparent
so it knows about the new path (end can use it in the commands)Manual Tests:
I hereby swear that: