Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid advanced modal color/stretch tweaks #6559

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Oct 17, 2024

Problem:

  1. The advanced grid modal always shows selected dropdown value with a subdued color
  2. The advaned grid modal doesn't offer stretch as an option for justify/align.

Fix:

  1. Fix the entries which are incorrectly set with placeholder: true
  2. Use FlexAlignment for the options of the align section
  3. Add stretch to the FlexJustifyContent enum

Fixes #6558

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Try me

Copy link

relativeci bot commented Oct 17, 2024

#14853 Bundle Size — 57.98MiB (~+0.01%).

82c9423(current) vs 916e8b9 master#14846(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14853
     Baseline
#14846
Regression  Initial JS 40.96MiB(~+0.01%) 40.96MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.04% 17.88%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4153 4153
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.33% 27.33%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14853
     Baseline
#14846
Regression  JS 57.97MiB (~+0.01%) 57.97MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/grid-advanced-modal-tweakProject dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi merged commit cc19746 into master Oct 17, 2024
15 checks passed
@ruggi ruggi deleted the fix/grid-advanced-modal-tweak branch October 17, 2024 16:48
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**

1. The advanced grid modal always shows selected dropdown value with a
subdued color
2. The advaned grid modal doesn't offer `stretch` as an option for
justify/align.

**Fix:**

1. Fix the entries which are incorrectly set with `placeholder: true`
2. Use `FlexAlignment` for the options of the `align` section
3. Add `stretch` to the `FlexJustifyContent` enum

Fixes #6558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix advanced grid modal selected color and stretch value
3 participants