-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Grid Track Labels and Resize Indicators #6566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruggi
approved these changes
Oct 18, 2024
#14869 Bundle Size — 57.98MiB (~+0.01%).3e57c79(current) vs 916e8b9 master#14866(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
Current #14869 |
Baseline #14866 |
|
---|---|---|
Initial JS | 40.97MiB (~+0.01% ) |
40.97MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 18% |
17.88% |
Chunks | 20 |
20 |
Assets | 22 |
22 |
Modules | 4153 |
4153 |
Duplicate Modules | 213 |
213 |
Duplicate Code | 27.33% |
27.33% |
Packages | 477 |
477 |
Duplicate Packages | 70 |
70 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #14869 |
Baseline #14866 |
|
---|---|---|
JS | 57.97MiB (~+0.01% ) |
57.97MiB |
HTML | 7.37KiB (-0.25% ) |
7.39KiB |
Bundle analysis report Branch fix/grid-labels Project dashboard
Generated by RelativeCI Documentation Report issue
gbalint
approved these changes
Oct 18, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
# **Problem:** The grid labels and the grid resize indicators are in a state of being fucked: ![image](https://github.com/user-attachments/assets/e68f433a-93e5-4f3a-92c7-a53764357651) ![image](https://github.com/user-attachments/assets/d2347204-9ae4-48de-bc5f-31592f81e751) ![image](https://github.com/user-attachments/assets/c0105ee6-793e-48d1-b68b-b2f9eb6f64e2) # **Goal:** Fix the various layout issues, and make the labels subdued until hovered. The hovered label should z-index over its siblings: ![image](https://github.com/user-attachments/assets/52b0f170-6d6b-4fed-8290-1eb6f9a022c8) # **Fix:** <img width="566" alt="image" src="https://github.com/user-attachments/assets/ade0a053-321f-438c-a9e2-d8538f5be293"> ![image](https://github.com/user-attachments/assets/9cb73a40-b205-45c8-a43f-2f1aae5ff6bf) **Commit Details:** - Split `GridResizingControl` into `GridTrackSizeLabelForDimension` and `GridResizingStripedIndicator` - Render _two_ helper grids, one for the label and one for the sizing indicator. This avoids future css intermingling problems, going forward bug fixing one should not meaningfully affect the other. - The helper grids use the blessed `getGridHelperStyleMatchingTargetGrid` style instead of manually picking an assortment of relevant grid properties. This simplifies our life 97% **Note:** The code could be further simplified, as this is now a copy-paste job. I tried to remove the obviously unnecessary things, but there's still a little too much div wrappers going on. **Manual Tests:** I hereby swear that: - [ ] I opened a hydrogen project and it loaded - [ ] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The grid labels and the grid resize indicators are in a state of being fucked:
Goal:
Fix the various layout issues, and make the labels subdued until hovered. The hovered label should z-index over its siblings:
Fix:
Commit Details:
GridResizingControl
intoGridTrackSizeLabelForDimension
andGridResizingStripedIndicator
getGridHelperStyleMatchingTargetGrid
style instead of manually picking an assortment of relevant grid properties. This simplifies our life 97%Note:
The code could be further simplified, as this is now a copy-paste job. I tried to remove the obviously unnecessary things, but there's still a little too much div wrappers going on.
Manual Tests:
I hereby swear that: