Handle Changing Imports In Canvas

[seanparsons]

Problem:
If we do a partial canvas re-render but a necessary import is also added, then the canvas errors out momentarily.

Cause:
The resolved values of the imports are buried in a property called requireResult which originates with require and resolve functions. Those functions are only rebuilt when the elements to re-render value is rerender-all-elements or when it has changed between the current canvas render and the prior one. With our recent changes to the canvas strategies to make them never supply the rerender-all-elements value, the failure case of the imports changing but the elements to re-render value not changing has become more likely.

In the case of grid insertion, the elements to re-render becomes the target path on hover, then when the user clicks it stays with that target path but the imports are added. Since there is no change in the former, the canvas logic is unable to find the new import in the old requireResult.

Fix:
Compare the old and current project contents and if their imports, combined top level arbitrary block or exports have changed then recreate the require and resolve functions. This replaces the previous check which looked at the current and previous versions of the elements to re-render property.

Commit Details:

• Removed the previous handling of shouldRerenderRef.
• Implemented projectContentsSameForRefreshRequire.
• Changed out old haveProjectImportsChanged call to use the new
  projectContentsSameForRefreshRequire.

[github-actions]

Try me

[relativeci]

#14903 Bundle Size — 57.97MiB (~+0.01%).

112d15b(current) vs 916e8b9 master#14901(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics   2 changes 1 regression

	Current #14903	Baseline #14901
Initial JS	40.96MiB(~+0.01%)	40.96MiB
Initial CSS	0B	0B
Cache Invalidation	18.51%	0%
Chunks	20	20
Assets	22	22
Modules	4152	4152
Duplicate Modules	213	213
Duplicate Code	27.34%	27.34%
Packages	477	477
Duplicate Packages	70	70

Bundle size by type   2 changes 1 regression 1 improvement

	Current #14903	Baseline #14901
JS	57.97MiB (~+0.01%)	57.97MiB
HTML	7.37KiB (-0.25%)	7.39KiB

Bundle analysis report Branch fix/handle-changing-imports-in-c... Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}