Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insertion of not yet imported component #6568

Closed
wants to merge 1 commit into from

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Oct 18, 2024

Problem:
When we grid-draw-to-insert a component which is not imported yet, the canvas errors out momentarily.

Fix:
According to this we need to one rerender-all-elements rendering to update the require fn: https://github.com/concrete-utopia/utopia/pull/2960/files#r1042121124

For reasons I don't really understand it seems enough to add the newly inserted elemenet to elements-to-rerender.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

@gbalint gbalint marked this pull request as ready for review October 18, 2024 15:04
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Try me

Copy link

relativeci bot commented Oct 18, 2024

#14875 Bundle Size — 57.98MiB (~+0.01%).

c37ef91(current) vs 916e8b9 master#14872(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14875
     Baseline
#14872
Regression  Initial JS 40.96MiB(~+0.01%) 40.96MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 17.99% 17.88%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4153 4153
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.33% 27.33%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14875
     Baseline
#14872
Regression  JS 57.97MiB (~+0.01%) 57.97MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/rectangle-insertionProject dashboard


Generated by RelativeCIDocumentationReport issue

@gbalint gbalint closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants