Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectangle insertion now inserts a div. #6579

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

seanparsons
Copy link
Contributor

Problem:
We want insertion of a Rectangle by pressing r to create a div instead of using the utopia-api component.

Fix:
In the following two locations, the definition of the Rectangle for insertion has been changed to insert a div:

  • The INSERT_RECTANGLE_SHORTCUT which handles the r keyboard press.
  • The component descriptor of the Rectangle element has been aligned with that of the above insertion.

Commit Details:

  • defaultRectangleElement now creates a div.
  • INSERT_RECTANGLE_SHORTCUT now doesn't include an import for utopia-api.
  • UtopiaApiComponents descriptor for a Rectangle now creates a div instead.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

- `defaultRectangleElement` now creates a `div`.
- `INSERT_RECTANGLE_SHORTCUT` now doesn't include an import for `utopia-api`.
- `UtopiaApiComponents` descriptor for a `Rectangle` now creates a `div` instead.
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Try me

Copy link

relativeci bot commented Oct 22, 2024

#14906 Bundle Size — 57.97MiB (~+0.01%).

b9fdbbd(current) vs 916e8b9 master#14901(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14906
     Baseline
#14901
Regression  Initial JS 40.96MiB(~+0.01%) 40.96MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 17.99% 0%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4152 4152
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.34% 27.34%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14906
     Baseline
#14901
Regression  JS 57.97MiB (~+0.01%) 57.97MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch refactor/rectangle-insert-insert...Project dashboard


Generated by RelativeCIDocumentationReport issue

@seanparsons seanparsons merged commit fc4cfb4 into master Oct 25, 2024
16 checks passed
@seanparsons seanparsons deleted the refactor/rectangle-insert-inserts-div branch October 25, 2024 13:40
liady pushed a commit that referenced this pull request Dec 13, 2024
- `defaultRectangleElement` now creates a `div`.
- `INSERT_RECTANGLE_SHORTCUT` now doesn't include an import for
`utopia-api`.
- `UtopiaApiComponents` descriptor for a `Rectangle` now creates a `div`
instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants