Rectangle insertion now inserts a div. #6579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We want insertion of a
Rectangle
by pressingr
to create adiv
instead of using theutopia-api
component.Fix:
In the following two locations, the definition of the
Rectangle
for insertion has been changed to insert a div:INSERT_RECTANGLE_SHORTCUT
which handles ther
keyboard press.Rectangle
element has been aligned with that of the above insertion.Commit Details:
defaultRectangleElement
now creates adiv
.INSERT_RECTANGLE_SHORTCUT
now doesn't include an import forutopia-api
.UtopiaApiComponents
descriptor for aRectangle
now creates adiv
instead.Manual Tests:
I hereby swear that: