Grid resize: remove shorthand, serialize other longhand when not auto #6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14909 Bundle Size — 57.98MiB (~+0.01%).60150e4(current) vs 916e8b9 master#14908(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14909 |
Baseline #14908 |
|
|---|---|---|
 Initial JS |
40.96MiB(~+0.01%) |
40.96MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
17.99% |
0% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4152 |
4152 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.33%(-0.04%) |
27.34% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14909 |
Baseline #14908 |
|
|---|---|---|
| JS |
57.97MiB (~+0.01%) |
57.97MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/grid-resize-shorthand-handl... Project dashboard
Generated by RelativeCI Documentation Report issue
bkrmendy
approved these changes
Oct 24, 2024
seanparsons
approved these changes
Oct 25, 2024
balazsbajorics
approved these changes
Oct 25, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
…#6581) **Problem:** If a grid is configured with the `gridTemplate` shorthand, resizing the grid does not handle that correctly. **Fix:** This PR handles `gridTemplate` shorthands during template changes via the canvas. **An incremental PR will do the same for the inspector template editing**. For example, if a grid is configured as follows: `gridTemplate: 1fr 2fr / 3fr 4fr`, changing its first column to `3.5fr` will result in the following style: ``` gridTemplateColumns: '3.5fr 4fr', gridTemplateRows: '1fr 2fr' ``` If a grid has a shorthand with an axis being the default (a single `auto` keyword), for example `gridTemplate: auto / 3fr 4fr`, the same change as above will result in: ``` gridTemplateColumns: '3.5fr 4fr', ``` Fixes #6580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If a grid is configured with the
gridTemplateshorthand, resizing the grid does not handle that correctly.Fix:
This PR handles
gridTemplateshorthands during template changes via the canvas.An incremental PR will do the same for the inspector template editing.
For example, if a grid is configured as follows:
gridTemplate: 1fr 2fr / 3fr 4fr, changing its first column to3.5frwill result in the following style:If a grid has a shorthand with an axis being the default (a single
autokeyword), for examplegridTemplate: auto / 3fr 4fr, the same change as above will result in:Fixes #6580