Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment/Decrement Fractional Grid Tracks #6588

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

seanparsons
Copy link
Contributor

Problem:
It would be helpful if fractional grid track values can be incremented or decremented using the arrow keys.

Fix:
Modified the keyboard event handler for the columns and rows to increment and decrement just the fractional values.

Commit Details:

  • Added isFR utility function.
  • Modified GridExpressionInput.onKeyDown to handle arrow up and down but only for fractional values.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

- Added `isFR` utility function.
- Modified `GridExpressionInput.onKeyDown` to handle arrow up and down
  but only for fractional values.
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Try me

Copy link

relativeci bot commented Oct 25, 2024

#14924 Bundle Size — 57.98MiB (~+0.01%).

e567e80(current) vs 916e8b9 master#14921(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14924
     Baseline
#14921
Regression  Initial JS 40.96MiB(~+0.01%) 40.96MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 17.99% 17.91%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4152 4152
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.33% 27.33%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14924
     Baseline
#14921
Regression  JS 57.97MiB (~+0.01%) 57.97MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch feature/increment-decrement-grid...Project dashboard


Generated by RelativeCIDocumentationReport issue

@seanparsons seanparsons merged commit 45649c6 into master Oct 25, 2024
16 checks passed
@seanparsons seanparsons deleted the feature/increment-decrement-grid-track branch October 25, 2024 15:16
liady pushed a commit that referenced this pull request Dec 13, 2024
- Added `isFR` utility function.
- Modified `GridExpressionInput.onKeyDown` to handle arrow up and down
but only for fractional values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants