Prevent click outside for radix select inside inspector modal #6591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
RadixSelect
components inside inspector modals don't actually respect their click outside handling, causing the modal to close down, moving focus back to whatever is behind, e.g. the canvas.Fix:
The problem is that this happens because RadixSelects are rendered in their own portal, which interferes with the one created by the inspector modal.
I tried multiple ways, e.g. setting the
onPointerDownOutside
prop of the Radix component itself, but it does not work. The only thing that seems to be working is adding an overlay div in the component's content itself, which will handle closing the select gracefully (see the recording please).Fixes #6590