Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Grid Column Gap Indicator Position #6592

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

seanparsons
Copy link
Contributor

Problem:
Column gap controls are off-center when at ≤ 1x zoom levels.

Fix:
Applied the same positioning logic to column gaps, that was already there for row gaps.

Screenshots:
Before:
image
After:
image

Commit Details:

  • Apply the same positioning for column gaps as was implemented for row gaps.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

- Apply the same positioning for column gaps as was implemented for row gaps;
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Try me

Copy link

relativeci bot commented Oct 25, 2024

#14933 Bundle Size — 57.98MiB (~+0.01%).

d489b15(current) vs 916e8b9 master#14928(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14933
     Baseline
#14928
Regression  Initial JS 40.97MiB(+0.01%) 40.96MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18% 0%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4152 4152
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.33% 27.33%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14933
     Baseline
#14928
Regression  JS 57.98MiB (~+0.01%) 57.97MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/correct-column-grid-gap-posi...Project dashboard


Generated by RelativeCIDocumentationReport issue

@seanparsons seanparsons merged commit 55ab421 into master Oct 28, 2024
16 checks passed
@seanparsons seanparsons deleted the fix/correct-column-grid-gap-positioning branch October 28, 2024 15:35
liady pushed a commit that referenced this pull request Dec 13, 2024
- Apply the same positioning for column gaps as was implemented for row
gaps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants