Do Not Insert In Progress Insertion #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `resetStateOnBlur` now clears the interaction session without applying changes and resets the editor mode to select mode.
seanparsons
requested review from
gbalint,
Rheeseyb,
ruggi,
balazsbajorics,
liady and
bkrmendy
#14938 Bundle Size — 57.98MiB (~+0.01%).8d0124c(current) vs 916e8b9 master#14936(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14938 |
Baseline #14936 |
|
|---|---|---|
 Initial JS |
40.97MiB(~+0.01%) |
40.97MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18% |
0% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4152 |
4152 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.33% |
27.33% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14938 |
Baseline #14936 |
|
|---|---|---|
| JS |
57.98MiB (~+0.01%) |
57.98MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch fix/do-not-insert-when-tabbing-a... Project dashboard
Generated by RelativeCI Documentation Report issue
ruggi
approved these changes
Nov 4, 2024
balazsbajorics
approved these changes
Nov 4, 2024
Merged
balazsbajorics
added a commit
that referenced
this pull request
Nov 7, 2024
#6593 Aggressively switches to edit mode on blur, but we only want that to happen if the user is in insert mode (which means a draw-to-insert interaction). **Fix** only switch to edit mode if the current mode is insert mode
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
- `resetStateOnBlur` now clears the interaction session without applying changes and resets the editor mode to select mode.
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
#6593 Aggressively switches to edit mode on blur, but we only want that to happen if the user is in insert mode (which means a draw-to-insert interaction). **Fix** only switch to edit mode if the current mode is insert mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When an insertion was in progress but not complete, tabbing away from the editor would result in a zero-sized element being inserted.
Cause:
The editor onBlur handler was clearing the interaction session, but applying any inflight changes which caused the element to be inserted.
Fix:
Now the interaction session is cancelled without applying changes and the editor mode is reset to select mode.
Commit Details:
resetStateOnBlurnow clears the interaction session without applying changes and resets the editor mode to select mode.Manual Tests:
I hereby swear that: