fastparquet v2024.5.0 #74
Conversation
TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot
PR has updated the recipe to account for the changes (see below for details).
The numpy 2.0 package itself is currently only available from a special release
channel (`conda-forge/label/numpy_rc`) and will not be available on the main
`conda-forge` channel until the release of numpy 2.0 GA.
The biggest change is that we no longer need to use the oldest available numpy
version at build time in order to support old numpy version at runtime - numpy
will by default use a compatible ABI for the oldest still-supported numpy versions.
Additionally, we no longer need to use `{{ pin_compatible("numpy") }}` as a
run requirement - this has been handled for more than two years now by a
run-export on the numpy package itself. The migrator will therefore remove
any occurrences of this.
However, by default, building against numpy 2.0 will assume that the package
is compatible with numpy 2.0, which is not necessarily the case. You should
check that the upstream package explicitly supports numpy 2.0, otherwise you
need to add a `- numpy <2` run requirement until that happens (check numpy
issue 26191 for an overview of the most important packages).
Note that the numpy release candidate promises to be ABI-compatible with the
final 2.0 release. This means that building against 2.0.0rc1 produces packages
that can be published to our main channels.
If you already want to use the numpy 2.0 release candidate yourself, you can do
```
conda config --add channels conda-forge/label/numpy_rc
```
or add this channel to your `.condarc` file directly.
### To-Dos:
* [ ] Match run-requirements for numpy (i.e. check upstream `pyproject.toml` or however the project specifies numpy compatibility)
* If upstream is not yet compatible with numpy 2.0, add `numpy <2` upper bound under `run:`.
* If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases.
* If upstream requires a minimum numpy version newer than 1.19, you can add `numpy >=x.y` under `run:`.
* [ ] Remove any remaining occurrences of `{{ pin_compatible("numpy") }}` that the bot may have missed.
PS. If the build does not compile anymore, this is almost certainly a sign that
the upstream project is not yet ready for numpy 2.0; do not close this PR until
a version compatible with numpy 2.0 has been released upstream and on this
feedstock (in the meantime, you can keep the bot from reopening this PR in
case of git conflicts by marking it as a draft).
…nda-forge-pinning 2024.05.17.03.43.53
…nda-forge-pinning 2024.05.21.18.33.22
regro-cf-autotick-bot
requested review from
TomAugspurger,
martindurant and
mrocklin
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
As this release supports NumPy 2, we could merge the NumPy 2 migrator PR ( #73 ) into this PR and ship the new release with NumPy 2 support to start |
|
I trust you, @jakirkham , if you think that's the right order of things |
|
If you are comfortable with the suggestions, please feel free to commit those, re-render, and merge The bot will create a new NumPy 2 migrator after, which can be merged in then That's probably the simplest path forward |
…1_he8c180' into 2024.5.0_h80d475
|
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.05.23.19.44.39
|
Thanks Martin! 🙏 Would take a look at CI when it is done and see if things look as expected. If so, should be good to ship Happy to answer any questions 🙂 |
|
It all ran and turned green. What other confirmation would we need? |
|
Depending on how a feedstock's CI is setup, it may not always propagate errors correctly to affect CI status. Am guessing that is not an issue here (especially as you made a tested these changes upstream yourself 🙂) |
| @@ -39,7 +40,6 @@ requirements: | |||
| - python | |||
| - pandas >=1.5.0 | |||
| - numpy >=1.20.3 | |||
There was a problem hiding this comment.
Since there is no upstream constraint, maybe we can drop this?
| - numpy >=1.20.3 | |
| - numpy |
There was a problem hiding this comment.
Since this was May 2021, and is no longer supported, I don't see any reason to allow older versions. I don't remember a specific reason for the restriction though.
There was a problem hiding this comment.
Ok no strong feelings either way. Please feel free to keep or drop as you see fit 🙂
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/9182806645 - please use this URL for debugging.