Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: add win #29

Open
wants to merge 74 commits into
base: main
Choose a base branch
from
Open

DEV: add win #29

wants to merge 74 commits into from

Conversation

MementoRC
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@MementoRC MementoRC marked this pull request as draft December 22, 2024 03:20
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@MementoRC
Copy link
Author

LMAO ... not quite the effect I was aiming for :(
This passes on my VM:

Packaging gtk2
Packaging gtk2-2.24.33-h94649b0_8
number of files: 475
   INFO: sysroot: 'C:/Windows/' files: '['winhlp32.exe', 'win.ini', 'twain_32/wiatwain.ds', 'twain_32.dll']'
   INFO (gtk2,bin/gtk-query-immodules-2.0.exe): Library\bin\libgtk-win32-2.0-0.dll found in this package
   INFO (gtk2,bin/gtk-query-immodules-2.0.exe): Needed DSO C:/Windows/System32/KERNEL32.dll found in $SYSROOT
   INFO (gtk2,bin/gtk-query-immodules-2.0.exe): Needed DSO C:/Windows/System32/downlevel/api-ms-win-crt-environment-l1-1-0.dll found in $SYSROOT
   ...

Back to the drawing board :'(

@MementoRC
Copy link
Author

@conda-forge-admin please rerender

@MementoRC
Copy link
Author

OMG ... finally! Same point as the ongoing local debug for dynamic linkage issues! I should be done tomorrow

@MementoRC
Copy link
Author

@pkgw There is the question of how I organized the build/host, everything that created overlinking I placed in build, though I am not sure this is acceptable. I am currently also testing this recipe - changed to rattler-style - with gtk-sharp (conda-forge/staged-recipes#28671)

@pkgw
Copy link
Contributor

pkgw commented Jan 12, 2025

@MementoRC If a dependency is causing an overlinking complaint, maybe it should move from host to build, or maybe you need to add one or more ignore_run_exports or ignore_run_exports_from statements to the recipe. The correct choice depends on which architecture the dep would need to be if we were doing a cross-compile build, which, uh, may not be very helpful advice. I can review this once the build is working.

@MementoRC
Copy link
Author

Thank you, I still had a typo on exists vs exit for win :(
We're green \0/, rerendering, it should take about an hour

@MementoRC MementoRC marked this pull request as ready for review January 12, 2025 16:30
@MementoRC
Copy link
Author

@pkgw @xhochy @jakirkham Gentle nudge, any concerns with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants