Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.11 #63

Merged
merged 6 commits into from
Mar 24, 2024
Merged

Update to 3.11 #63

merged 6 commits into from
Mar 24, 2024

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Oct 18, 2023

Closes #62

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libblas' output doesn't have any tests.
  • It looks like the 'libtmglib' output doesn't have any tests.
  • It looks like the 'libcblas' output doesn't have any tests.
  • It looks like the 'liblapack' output doesn't have any tests.
  • It looks like the 'liblapacke' output doesn't have any tests.
  • It looks like the 'blas-devel' output doesn't have any tests.
  • It looks like the 'lapack' output doesn't have any tests.

@jschueller
Copy link
Contributor Author

@conda-forge-admin please rerender

@jschueller
Copy link
Contributor Author

ready to go @conda-forge/lapack

@h-vetinari
Copy link
Member

We waited a really long time to get #51 merged, because we basically want all BLAS/LAPACK implementations to support the same LAPACK feature level, and MKL is generally far behind.

Also, we haven't enabled 3.10 in the blas-metapackage yet, which is IMO the next reasonable step...

@jschueller
Copy link
Contributor Author

ok, yes, I figured 3.9 was really old :)
but anyway this is independent of the global pinning and we can still update the feedstock to ease the next version update

@isuruf
Copy link
Member

isuruf commented Oct 18, 2023

Merging this as is will make the netlib variant higher priority. Here's what we can do,

  1. Merge this PR with target to conda-forge/label/lapack
  2. Build blas-metapackage without MKL and drop windows for 3.11
  3. Move these pacakges to main label

To be clear this only gives the ability of downstream feedstocks to target new APIs in 3.10 and 3.11, but not any performance benefits as we enable latest versions of openblas, MKL, etc with 3.9.

@jschueller
Copy link
Contributor Author

ok, in this case it can wait, I let you decide

@h-vetinari
Copy link
Member

The Intel team helping us with repackaging MKL has asked to be able to test blas metapackage against LAPACK 3.11, as there are failures with 3.10.1.

The main branch here already points to a separate label:

channel_targets:
- conda-forge lapack_rc

so we can safely merge this PR. Then it becomes easy to test the various implementations against 3.11 on the blas feedstock, without yet making this generally available.

PS. Thanks a lot for the PR!

@h-vetinari h-vetinari merged commit be316c3 into conda-forge:main Mar 24, 2024
7 checks passed
@jschueller jschueller deleted the 311 branch March 24, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants