Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for adam-robotics Python package #21894

Merged
merged 13 commits into from
May 25, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 28, 2023

Add recipe for the adam-robotics. The name of the Python module is adam, while the PyPI package is adam-robotics, so here for consistency with PyPI we use adam-robotics.

Repo: https://github.com/ami-iit/ADAM .
PyPI page: https://pypi.org/project/adam-robotics/ .

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/adam-robotics) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

Blocked by #21870 .

@Giulero I added you as a mantainer, are you interested in being a mantainer? Please reply explicitly in the issue as it is required by conda-forge rules, thanks!

@Giulero
Copy link

Giulero commented Jan 29, 2023

Hi @traversaro ! Sure! Thanks a lot :)

@traversaro traversaro closed this May 3, 2023
@traversaro traversaro reopened this May 3, 2023
@traversaro
Copy link
Contributor Author

@Giulero the test_gravity_term test is not passing on Linux for both jax and pytorch, do you have any idea what could be the cause? Thanks!

@traversaro
Copy link
Contributor Author

@Giulero the test_gravity_term test is not passing on Linux for both jax and pytorch, do you have any idea what could be the cause? Thanks!

The jaxlib, jax and pytorch version are exactly the one that are in ami-iit/adam#38 were tests are passing.

@traversaro traversaro closed this May 8, 2023
@traversaro traversaro reopened this May 8, 2023
@traversaro traversaro mentioned this pull request May 8, 2023
@traversaro
Copy link
Contributor Author

traversaro commented May 13, 2023

@Giulero the test_gravity_term test is not passing on Linux for both jax and pytorch, do you have any idea what could be the cause? Thanks!

The jaxlib, jax and pytorch version are exactly the one that are in ami-iit/ADAM#38 were tests are passing.

Ok, I was able to reproduce the issue. It is happening if one uses the quay.io/condaforge/linux-anvil-cos7-x86_64 docker image, and not if one uses Ubuntu 22.04 in ami-iit/adam#38 .

@traversaro
Copy link
Contributor Author

traversaro commented May 14, 2023

@Giulero the test_gravity_term test is not passing on Linux for both jax and pytorch, do you have any idea what could be the cause? Thanks!

The jaxlib, jax and pytorch version are exactly the one that are in ami-iit/ADAM#38 were tests are passing.

Ok, I was able to reproduce the issue. It is happening if one uses the quay.io/condaforge/linux-anvil-cos7-x86_64 docker image, and not if one uses Ubuntu 22.04 in ami-iit/ADAM#38 .

It turns out that the problem happens for glibc <= 2.25 and does not happen for glibc >= 2.26 : ami-iit/adam#38 (comment) . This is probably related to some strange interaction of jax/pytorch with glibc <= 2.25, and not directly related to adam-robotics. Furthermore, this happens just in a specific test case for some dependencies that by default are not insalled by jax, so I think we can just suppress the failing tests, and mark the PR as ready for review.

Actually to get the test to pass also on Windows, we can directly disable the pytorch/jax related code, we can try to re-enable once the recipe is in the feedstock.

@traversaro
Copy link
Contributor Author

@conda-forge/help-python @conda-forge/staged-recipes the PR is ready for review, thanks!

@traversaro

This comment was marked as outdated.

@traversaro

This comment was marked as outdated.

@traversaro traversaro closed this May 15, 2023
@traversaro traversaro reopened this May 15, 2023
@traversaro

This comment was marked as outdated.

@traversaro
Copy link
Contributor Author

The flaky tests were fixed by backporting ami-iit/adam#40 , now the recipe is actually ready for review, thanks! @conda-forge/help-python @conda-forge/staged-recipes

@ocefpaf ocefpaf merged commit 766d613 into conda-forge:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants