-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for adam-robotics Python package #21894
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi @traversaro ! Sure! Thanks a lot :) |
9ad560f
to
1308670
Compare
@Giulero the |
The |
Ok, I was able to reproduce the issue. It is happening if one uses the |
It turns out that the problem happens for glibc <= 2.25 and does not happen for glibc >= 2.26 : ami-iit/adam#38 (comment) . This is probably related to some strange interaction of jax/pytorch with glibc <= 2.25, and not directly related to adam-robotics. Furthermore, this happens just in a specific test case for some dependencies that by default are not insalled by jax, so I think we can just suppress the failing tests, and mark the PR as ready for review. Actually to get the test to pass also on Windows, we can directly disable the pytorch/jax related code, we can try to re-enable once the recipe is in the feedstock. |
@conda-forge/help-python @conda-forge/staged-recipes the PR is ready for review, thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The flaky tests were fixed by backporting ami-iit/adam#40 , now the recipe is actually ready for review, thanks! @conda-forge/help-python @conda-forge/staged-recipes |
Add recipe for the adam-robotics. The name of the Python module is
adam
, while thePyPI
package isadam-robotics
, so here for consistency with PyPI we useadam-robotics
.Repo: https://github.com/ami-iit/ADAM .
PyPI page: https://pypi.org/project/adam-robotics/ .
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).