Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add urdf-parser-py and torchkin #23206

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Jun 29, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/urdf-parser-py) and found some lint.

Here's what I've got...

For recipes/urdf-parser-py:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/torchkin, recipes/urdf-parser-py) and found some lint.

Here's what I've got...

For recipes/urdf-parser-py:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/torchkin, recipes/urdf-parser-py) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

Tobias-Fischer commented Jun 29, 2023

Hi @conda-forge/help-python - this is ready for review. It adds another required package for conda-forge/theseus-ai-feedstock#7 (@ocefpaf already kindly merged #23199).

/cc @traversaro - this adds urdf-parser-py, which is also packaged by ROS.

PS: As package is python: noarch, the passing linux build is sufficient.

@ocefpaf ocefpaf merged commit 80ef469 into conda-forge:main Jun 29, 2023
@Tobias-Fischer Tobias-Fischer deleted the patch-29 branch June 29, 2023 21:40
@Tobias-Fischer
Copy link
Contributor Author

Many thanks, that was quick @ocefpaf :)

@traversaro
Copy link
Contributor

traversaro commented Jun 29, 2023

The urdf_parser_py Python module was also packaged as part of the urdfdom-py Python package in #21870 (the naming was choosen for consistency with ROS/package.xml metadata). Probably we may want to make the two package converge.

@Tobias-Fischer
Copy link
Contributor Author

Ah, damn .. apologies for that! I should have dug deeper :(

I requested to archive the urdf-parser-py feedstock here: conda-forge/admin-requests#744
At least then we will have some visibility for the future.

@traversaro
Copy link
Contributor

Ah, damn .. apologies for that! I should have dug deeper :(

No problem, the whole different naming between the package and the module is quite confusing. Furthermore, the package on PyPI is stuck to quite an old version, but that is another story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants