Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gtest-parallel@2022.06.21-0, open-belex@1.0.3-0, open-belex-libs@1.0.3-0, and gsi-baryon@1.6.3-0 #25205

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

dylon
Copy link

@dylon dylon commented Feb 2, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gsi-baryon, recipes/gtest-parallel, recipes/open-belex, recipes/open-belex-libs, recipes/open-belex-tests) and found some lint.

Here's what I've got...

For recipes/gsi-baryon:

  • The recipe must have some tests.
  • Recipe maintainer "Dylon Edwards" does not exist
  • Recipe maintainer "Ondřej Čertík" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards, Ondřej Čertík. Please ask them to comment on this PR if they are.
  • requirements: build: cmake=3.26.4 must contain a space between the name and the pin, i.e. cmake =3.26.4
  • requirements: build: gtest=1.13.0 must contain a space between the name and the pin, i.e. gtest =1.13.0
  • requirements: build: make=4.3 must contain a space between the name and the pin, i.e. make =4.3
  • requirements: build: open-belex-libs>=1.0.1,<2.0.0 must contain a space between the name and the pin, i.e. open-belex-libs >=1.0.1,<2.0.0
  • requirements: build: open-belex>=1.0.1,<2.0.0 must contain a space between the name and the pin, i.e. open-belex >=1.0.1,<2.0.0
  • requirements: build: python=3.11 must contain a space between the name and the pin, i.e. python =3.11
  • requirements: build: rapidcheck=2023.4.13 must contain a space between the name and the pin, i.e. rapidcheck =2023.4.13
  • requirements: build: yaml-cpp=0.7.0 must contain a space between the name and the pin, i.e. yaml-cpp =0.7.0
  • requirements: run: gtest-parallel=2022.06.21 must contain a space between the name and the pin, i.e. gtest-parallel =2022.06.21
  • requirements: run: gtest=1.13.0 must contain a space between the name and the pin, i.e. gtest =1.13.0
  • requirements: run: python=3.11 must contain a space between the name and the pin, i.e. python =3.11
  • requirements: run: rapidcheck=2023.4.13 must contain a space between the name and the pin, i.e. rapidcheck =2023.4.13
  • requirements: run: yaml-cpp=0.7.0 must contain a space between the name and the pin, i.e. yaml-cpp =0.7.0

For recipes/gtest-parallel:

  • The recipe must have some tests.
  • Recipe maintainer "Dylon Edwards" does not exist
  • Recipe maintainer "Ondřej Čertík" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards, Ondřej Čertík. Please ask them to comment on this PR if they are.
  • requirements: host: python>=3.10.6 must contain a space between the name and the pin, i.e. python >=3.10.6
  • requirements: host: coreutils=9.1 must contain a space between the name and the pin, i.e. coreutils =9.1
  • requirements: run: python>=3.10.6 must contain a space between the name and the pin, i.e. python >=3.10.6
  • requirements: run: gtest>=1.13.0 must contain a space between the name and the pin, i.e. gtest >=1.13.0

For recipes/gtest-parallel:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/open-belex:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.
  • requirements: host: python=3.11 must contain a space between the name and the pin, i.e. python =3.11
  • requirements: host: setuptools=65.5.0 must contain a space between the name and the pin, i.e. setuptools =65.5.0
  • requirements: run: Cerberus=1.3.4 must contain a space between the name and the pin, i.e. Cerberus =1.3.4
  • requirements: run: Jinja2=3.1.2 must contain a space between the name and the pin, i.e. Jinja2 =3.1.2
  • requirements: run: PyYAML=6.0 must contain a space between the name and the pin, i.e. PyYAML =6.0
  • requirements: run: click=8.1.6 must contain a space between the name and the pin, i.e. click =8.1.6
  • requirements: run: numpy=1.25.1 must contain a space between the name and the pin, i.e. numpy =1.25.1
  • requirements: run: python=3.11 must contain a space between the name and the pin, i.e. python =3.11
  • requirements: run: reactivex=4.0.4 must contain a space between the name and the pin, i.e. reactivex =4.0.4

For recipes/open-belex-libs:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.
  • requirements: host: python=3.11 must contain a space between the name and the pin, i.e. python =3.11
  • requirements: host: setuptools=65.5.0 must contain a space between the name and the pin, i.e. setuptools =65.5.0
  • requirements: run: python=3.11 must contain a space between the name and the pin, i.e. python =3.11
  • requirements: run: open-belex>=1.0.0,<2.0.0 must contain a space between the name and the pin, i.e. open-belex >=1.0.0,<2.0.0

For recipes/open-belex-tests:

  • Recipe maintainer "Dylon Edwards" does not exist
  • Recipe maintainer "Ondřej Čertík" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards, Ondřej Čertík. Please ask them to comment on this PR if they are.
  • requirements: host: python=3.11 must contain a space between the name and the pin, i.e. python =3.11
  • requirements: host: setuptools=65.5.0 must contain a space between the name and the pin, i.e. setuptools =65.5.0
  • requirements: run: bash=5.2.15 must contain a space between the name and the pin, i.e. bash =5.2.15
  • requirements: run: click=8.1.6 must contain a space between the name and the pin, i.e. click =8.1.6
  • requirements: run: coreutils=9.3 must contain a space between the name and the pin, i.e. coreutils =9.3
  • requirements: run: gsi-baryon=1.6.2 must contain a space between the name and the pin, i.e. gsi-baryon =1.6.2
  • requirements: run: hypothesis=6.82.0 must contain a space between the name and the pin, i.e. hypothesis =6.82.0
  • requirements: run: numpy=1.25.1 must contain a space between the name and the pin, i.e. numpy =1.25.1
  • requirements: run: open-belex-libs>=1.0.1,<2.0.0 must contain a space between the name and the pin, i.e. open-belex-libs >=1.0.1,<2.0.0
  • requirements: run: open-belex>=1.0.1,<2.0.0 must contain a space between the name and the pin, i.e. open-belex >=1.0.1,<2.0.0
  • requirements: run: pytest=7.4.0 must contain a space between the name and the pin, i.e. pytest =7.4.0
  • requirements: run: python=3.11 must contain a space between the name and the pin, i.e. python =3.11

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gsi-baryon, recipes/gtest-parallel, recipes/open-belex, recipes/open-belex-libs) and found some lint.

Here's what I've got...

For recipes/gsi-baryon:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.

For recipes/gtest-parallel:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].
  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/open-belex:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.

For recipes/open-belex-libs:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gsi-baryon, recipes/gtest-parallel, recipes/open-belex, recipes/open-belex-libs) and found some lint.

Here's what I've got...

For recipes/gsi-baryon:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.

For recipes/gtest-parallel:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.

For recipes/open-belex:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.

For recipes/open-belex-libs:

  • Recipe maintainer "Dylon Edwards" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Dylon Edwards. Please ask them to comment on this PR if they are.

@dylon
Copy link
Author

dylon commented Feb 2, 2024

@conda-forge-admin, please add user @dylon

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gsi-baryon, recipes/gtest-parallel, recipes/open-belex, recipes/open-belex-libs) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gsi-baryon, recipes/gtest-parallel, recipes/open-belex, recipes/open-belex-libs) and found some lint.

Here's what I've got...

For recipes/gsi-baryon:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [13]

For recipes/open-belex:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]

For recipes/open-belex-libs:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gsi-baryon, recipes/gtest-parallel, recipes/open-belex, recipes/open-belex-libs) and found it was in an excellent condition.

@dylon dylon changed the title Adds gtest-parallel@2022.06.21-0, open-belex@1.0.2-0, open-belex-libs@1.0.2-0, gsi-baryon@1.6.3-0, and open-belex-tests@1.0.3-0 Adds gtest-parallel@2022.06.21-0, open-belex@1.0.2-0, open-belex-libs@1.0.2-0, and gsi-baryon@1.6.3-0 Feb 2, 2024
@dylon
Copy link
Author

dylon commented Feb 2, 2024

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link

github-actions bot commented Feb 2, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@dylon
Copy link
Author

dylon commented Feb 2, 2024

conda-forge/help-python-c

@dylon dylon marked this pull request as draft February 2, 2024 21:28
@dylon dylon changed the title Adds gtest-parallel@2022.06.21-0, open-belex@1.0.2-0, open-belex-libs@1.0.2-0, and gsi-baryon@1.6.3-0 Adds gtest-parallel@2022.06.21-0, open-belex@1.0.3-0, open-belex-libs@1.0.3-0, and gsi-baryon@1.6.3-0 Feb 2, 2024
@dylon dylon marked this pull request as ready for review February 2, 2024 21:43
@dylon
Copy link
Author

dylon commented Feb 2, 2024

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link

github-actions bot commented Feb 2, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@dylon
Copy link
Author

dylon commented Feb 3, 2024

@conda-forge/help-python-c, ready for review!

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heavy pins in the recipe here won't be sustainable and will lead to the point that this package won't be installable alongside other packages on conda-forge.

Comment on lines +20 to +27
- cmake =3.26.4
- gtest =1.13.0
- make =4.3
- open-belex-libs >=1.0.1,<2.0.0
- open-belex >=1.0.1,<2.0.0
- python =3.11
- rapidcheck =2023.4.13
- yaml-cpp =0.7.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except make and cmake, everything should be in host and the run section should only contain python

Suggested change
- cmake =3.26.4
- gtest =1.13.0
- make =4.3
- open-belex-libs >=1.0.1,<2.0.0
- open-belex >=1.0.1,<2.0.0
- python =3.11
- rapidcheck =2023.4.13
- yaml-cpp =0.7.0
- cmake =3.26.4
- gtest =1.13.0
- make =4.3
- open-belex-libs >=1.0.1,<2.0.0
- open-belex >=1.0.1,<2.0.0
- python =3.11
- rapidcheck =2023.4.13
- yaml-cpp =0.7.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand the purpose of host dependencies, how are they different from the build and run dependencies? Also, open-belex, open-belex-libs, and python are only used during the compilation process to generate the respective libraries. Since they are not runtime dependencies, should they still be moved from build to host?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is for compiler, host for dependencies you build against and run is what you need at runtime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is the architecture of the machine you are building on, host is the architecture you are building for. In the cross-compilation case, they will differ.

number: 0

requirements:
build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build:
host:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants