-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds gtest-parallel@2022.06.21-0, open-belex@1.0.3-0, open-belex-libs@1.0.3-0, and gsi-baryon@1.6.3-0 #25205
base: main
Are you sure you want to change the base?
Conversation
…@1.0.2-0, gsi-baryon@1.6.3-0, and open-belex-tests@1.0.3-0
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gsi-baryon:
For recipes/gtest-parallel:
For recipes/gtest-parallel:
Documentation on acceptable licenses can be found here. For recipes/open-belex:
For recipes/open-belex-libs:
For recipes/open-belex-tests:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gsi-baryon:
For recipes/gtest-parallel:
For recipes/open-belex:
For recipes/open-belex-libs:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gsi-baryon:
For recipes/gtest-parallel:
For recipes/open-belex:
For recipes/open-belex-libs:
|
@conda-forge-admin, please add user @dylon |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gsi-baryon:
For recipes/open-belex:
For recipes/open-belex-libs:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please ping team |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
conda-forge/help-python-c |
@conda-forge-admin, please ping team |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
@conda-forge/help-python-c, ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heavy pins in the recipe here won't be sustainable and will lead to the point that this package won't be installable alongside other packages on conda-forge.
- cmake =3.26.4 | ||
- gtest =1.13.0 | ||
- make =4.3 | ||
- open-belex-libs >=1.0.1,<2.0.0 | ||
- open-belex >=1.0.1,<2.0.0 | ||
- python =3.11 | ||
- rapidcheck =2023.4.13 | ||
- yaml-cpp =0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except make and cmake, everything should be in host and the run section should only contain python
- cmake =3.26.4 | |
- gtest =1.13.0 | |
- make =4.3 | |
- open-belex-libs >=1.0.1,<2.0.0 | |
- open-belex >=1.0.1,<2.0.0 | |
- python =3.11 | |
- rapidcheck =2023.4.13 | |
- yaml-cpp =0.7.0 | |
- cmake =3.26.4 | |
- gtest =1.13.0 | |
- make =4.3 | |
- open-belex-libs >=1.0.1,<2.0.0 | |
- open-belex >=1.0.1,<2.0.0 | |
- python =3.11 | |
- rapidcheck =2023.4.13 | |
- yaml-cpp =0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand the purpose of host
dependencies, how are they different from the build
and run
dependencies? Also, open-belex
, open-belex-libs
, and python
are only used during the compilation process to generate the respective libraries. Since they are not runtime dependencies, should they still be moved from build
to host
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build
is for compiler, host
for dependencies you build against and run
is what you need at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is the architecture of the machine you are building on, host
is the architecture you are building for. In the cross-compilation case, they will differ.
number: 0 | ||
|
||
requirements: | ||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build: | |
host: |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).