-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added recipes for neuraloperators
and configmypy
#28667
base: main
Are you sure you want to change the base?
added recipes for neuraloperators
and configmypy
#28667
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/configmypy/meta.yaml:
For recipes/neuraloperator/meta.yaml:
For recipes/neuraloperator/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12432957112. Examine the logs at this URL for more detail. |
…arthakpati/staged-recipes into neuraloperators_and_configmypy
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/configmypy/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12433100394. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Error is coming from the fact that one of the dependencies does not have the latest version on conda, yet. This PR fixes it: conda-forge/torch-harmonics-feedstock#8 |
@conda-forge/help-python please review |
Co-authored-by: Filipe <ocefpaf@gmail.com>
@ocefpaf the recipe is not building without the |
It should. Let's see the logs. Please make the change. |
Co-authored-by: Filipe <ocefpaf@gmail.com>
So weird. Anyway, this should be good to go (the Windows builds are failing because of torch, which should be fine once the actual recipe goes through). Thanks, @ocefpaf |
recipes/neuraloperator/meta.yaml
Outdated
# imports: | ||
# - neuralop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you are not doing the import test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the import test was not working correctly (see 61114c5), hence I have left it commented. I will discuss this with the package authors and suggest a couple of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plaease re-add it here so we can see the logs and how it fails.
Co-authored-by: Filipe <ocefpaf@gmail.com>
Co-authored-by: Filipe <ocefpaf@gmail.com>
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12467797927. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@beckermr do you have any idea what is going on here? Or are we supposed to define the python_min again? |
Try opening two separate PRs, one for each recipe. If you examine the logs carefully, there is an error where staged-recipes tries to build configmypy second, not first as it should. I think this is the actual error and the python_min stuff is a red herring. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).