Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdaptiveCpp #28679

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Dec 22, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/AdaptiveCpp/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta jeongseok-meta marked this pull request as ready for review December 22, 2024 08:49
@jeongseok-meta
Copy link
Contributor Author

@conda-forge/help-c-cpp, ready for review!

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/AdaptiveCpp/meta.yaml) and found some lint.

Here's what I've got...

For recipes/AdaptiveCpp/meta.yaml:

  • ❌ The test section contained an unexpected subsection name. script is not a valid subsection name.

For recipes/AdaptiveCpp/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12726921929. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/AdaptiveCpp/meta.yaml) and found it was in an excellent condition.

recipes/AdaptiveCpp/meta.yaml Outdated Show resolved Hide resolved
- llvm >=14,<19
- spirv-tools
run:
- llvm >=14,<19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there's still warnings about spriv and llvm packages.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12727489976. Examine the logs at this URL for more detail.

@jeongseok-meta
Copy link
Contributor Author

jeongseok-meta commented Jan 11, 2025

Hi @carterbox, thank you so much for taking the time to review!

I'm not super familiar with how the boost conda package is built, but the current setup is the best configuration I've found so far. I'd be happy to consider a better solution if one exists.

Including boost, could we possibly address the export warnings after the feedstock repo is created for faster iterations, including OSX tests? If this is okay with you, I'd greatly appreciate it. To be honest, the export warnings are a bit fuzzy to me and take too much time to iterate.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/AdaptiveCpp/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta
Copy link
Contributor Author

@conda-forge/help-c-cpp, ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants