-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AdaptiveCpp #28679
base: main
Are you sure you want to change the base?
Add AdaptiveCpp #28679
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp, ready for review! |
Co-authored-by: Daniel Ching <9604511+carterbox@users.noreply.github.com>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/AdaptiveCpp/meta.yaml:
For recipes/AdaptiveCpp/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12726921929. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- llvm >=14,<19 | ||
- spirv-tools | ||
run: | ||
- llvm >=14,<19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there's still warnings about spriv and llvm packages.
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12727489976. Examine the logs at this URL for more detail. |
Hi @carterbox, thank you so much for taking the time to review! I'm not super familiar with how the boost conda package is built, but the current setup is the best configuration I've found so far. I'd be happy to consider a better solution if one exists. Including boost, could we possibly address the export warnings after the feedstock repo is created for faster iterations, including OSX tests? If this is okay with you, I'd greatly appreciate it. To be honest, the export warnings are a bit fuzzy to me and take too much time to iterate. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp, ready for review! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).