Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torchx #28688

Merged
merged 9 commits into from
Dec 24, 2024
Merged

Add torchx #28688

merged 9 commits into from
Dec 24, 2024

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Dec 24, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/torchx/meta.yaml) and found some lint.

Here's what I've got...

For recipes/torchx/meta.yaml:

  • requirements: run: fsspec>=2023.10.0 must contain a space between the name and the pin, i.e. fsspec >=2023.10.0

For recipes/torchx/meta.yaml:

  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12476930243. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 24, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/torchx/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/torchx/meta.yaml:

  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12486806275. Examine the logs at this URL for more detail.

@jeongseok-meta jeongseok-meta marked this pull request as ready for review December 24, 2024 05:51
@jeongseok-meta
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

commands:
- pip check
requires:
- numpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is numpy needed here?

test:
imports:
- torchx
commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongseok-meta
Copy link
Contributor Author

@synapticarbors I've addressed your comments, and this PR is now ready for another review. Thank you!

@synapticarbors synapticarbors merged commit 935bae8 into conda-forge:main Dec 24, 2024
7 checks passed
@jeongseok-meta jeongseok-meta deleted the torchx branch December 24, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants