-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add torchx #28688
Add torchx #28688
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/torchx/meta.yaml:
For recipes/torchx/meta.yaml:
Documentation on acceptable licenses can be found here. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12476930243. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/torchx/meta.yaml:
Documentation on acceptable licenses can be found here. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12486806275. Examine the logs at this URL for more detail. |
@conda-forge/help-python, ready for review! |
recipes/torchx/meta.yaml
Outdated
commands: | ||
- pip check | ||
requires: | ||
- numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is numpy
needed here?
test: | ||
imports: | ||
- torchx | ||
commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably test the cli here:
https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#test-commands
@synapticarbors I've addressed your comments, and this PR is now ready for another review. Thank you! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).