Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FF (second attempt) #28692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Dec 24, 2024


This is a second attempt at PR #28680 given @h-vetinari's information in conda-forge/ff-static-feedstock#1. After this goes in I'll ask that https://github.com/conda-forge/ff-static-feedstock get archived and add a required feedstock_to_output_mapping as pointed to in conda-forge/ff-static-feedstock#1 (comment).

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@matthewfeickert
Copy link
Member Author

@conda-forge/staged-recipes, ready for review! This is a fortran recipe.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 24, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ff/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/ff/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12489979071. Examine the logs at this URL for more detail.

- name: {{ name }}-static

build:
skip: true # [win or (osx and x86)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things work for arm64 osx but not x86, so skipping x86 for the time being, but not using # [not linux] to allow for rerenders to add additional builds.

@matthewfeickert matthewfeickert changed the title Add FF Add FF (second attempt) Dec 24, 2024
* Add FF v2.0 from 1998 as a ff-static output of the feedstock.
   - c.f. https://github.com/hep-packaging-coordination/ff
* FF is now archival software but is still required in areas of particle physics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants