Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add r-cpp11armadillo #28698

Merged
merged 3 commits into from
Dec 26, 2024
Merged

add r-cpp11armadillo #28698

merged 3 commits into from
Dec 26, 2024

Conversation

danielnachun
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@danielnachun
Copy link
Contributor Author

We'll need this for conda-forge/r-lotri-feedstock#13, which is ultimately needed for conda-forge/r-rxode2-feedstock#12.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-cpp11armadillo/meta.yaml) and found it was in an excellent condition.

@danielnachun
Copy link
Contributor Author

@conda-forge/help-r This is now ready for review. Please disregard the Windows failure as this package is noarch: generic.

@danielnachun
Copy link
Contributor Author

For some additional context, this package is noarch: generic because it only provides header files to Armadillo to be used by other packages and does do any compilation itself.

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good; just a couple minor adjusts suggested.


test:
commands:
- $R -e "library('cpp11armadillo')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a nit as it's noarch, but the win only seems to fail because this is not conditional:

Suggested change
- $R -e "library('cpp11armadillo')"
- $R -e "library('cpp11armadillo')" # [not win]
- "\"%R%\" -e \"library('cpp11armadillo')\"" # [win]

- $R -e "library('cpp11armadillo')"

about:
home: https://pacha.dev/cpp11armadillo/, https://github.com/pachadotdev/cpp11armadillo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split urls:

Suggested change
home: https://pacha.dev/cpp11armadillo/, https://github.com/pachadotdev/cpp11armadillo
home: https://pacha.dev/cpp11armadillo/
dev_url: https://github.com/pachadotdev/cpp11armadillo

@danielnachun
Copy link
Contributor Author

I guess noarch: generic recipes can have selectors in the test block without failing linting! We should be all set here now.

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@mfansler mfansler merged commit 5d5e114 into conda-forge:main Dec 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants