-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add r-cpp11armadillo #28698
add r-cpp11armadillo #28698
Conversation
We'll need this for conda-forge/r-lotri-feedstock#13, which is ultimately needed for conda-forge/r-rxode2-feedstock#12. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-r This is now ready for review. Please disregard the Windows failure as this package is |
For some additional context, this package is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good; just a couple minor adjusts suggested.
recipes/r-cpp11armadillo/meta.yaml
Outdated
|
||
test: | ||
commands: | ||
- $R -e "library('cpp11armadillo')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of a nit as it's noarch, but the win only seems to fail because this is not conditional:
- $R -e "library('cpp11armadillo')" | |
- $R -e "library('cpp11armadillo')" # [not win] | |
- "\"%R%\" -e \"library('cpp11armadillo')\"" # [win] |
recipes/r-cpp11armadillo/meta.yaml
Outdated
- $R -e "library('cpp11armadillo')" | ||
|
||
about: | ||
home: https://pacha.dev/cpp11armadillo/, https://github.com/pachadotdev/cpp11armadillo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split urls:
home: https://pacha.dev/cpp11armadillo/, https://github.com/pachadotdev/cpp11armadillo | |
home: https://pacha.dev/cpp11armadillo/ | |
dev_url: https://github.com/pachadotdev/cpp11armadillo |
80a83e3
to
35d03b2
Compare
I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding!
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).