Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to address UpdateVariableFunctionality and Inprogress throwing error issue #100

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

Jithesh-poojary
Copy link
Collaborator

Changes to address the below

  1. Implement the update workflow variables functionality (No SDK support for the Update Workflow Variables Endpoint? #95),
  2. Inprogress throws exception when default param value after callbackAfterSeconds (InProgress throws exception when using default param value for callbackAfterSeconds #91)

Closes #91 #95

Jithesh.Poojary added 4 commits January 10, 2024 13:11
1. update variables functionality,
2. Inprogress throws exception when default param value after callbackAfterSeconds
1. update variables functionality,
2. Inprogress throws exception when default param value after callbackAfterSeconds
@manan164
Copy link
Collaborator

Hi @Jithesh-poojary , Can you please the build is failing? I think there is a lint fix since the spacing has been changed in this PR.

@Jithesh-poojary
Copy link
Collaborator Author

Hi @Jithesh-poojary , Can you please the build is failing? I think there is a lint fix since the spacing has been changed in this PR.

Yeah, fixed the issues

@BommannanRa BommannanRa requested review from v1r3n and manan164 January 17, 2024 04:46
@v1r3n v1r3n merged commit 399ed7c into conductor-sdk:main Jan 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InProgress throws exception when using default param value for callbackAfterSeconds
3 participants