Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Human Task Resource API #105

Merged
merged 11 commits into from
Feb 22, 2024
Merged

[New] Human Task Resource API #105

merged 11 commits into from
Feb 22, 2024

Conversation

Mkatari3700
Copy link
Contributor

Changes to address the following

  1. Added new HumanTaskResourceAPI
  2. Added test case sample for human task (one get call)
  3. Added constants file

Copy link
Member

@v1r3n v1r3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments with method names and internal methods that we should not expose in the sdk.

/// <exception cref="ApiException">Thrown when fails to make API call</exception>
/// <param name="_100"></param>
/// <returns>Dictionary&lt;string, Object&gt;</returns>
Dictionary<string, Object> BackPopulateFullTextIndex(int? _100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this API -- this is only for some maintenance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

/// <exception cref="ApiException">Thrown when fails to make API call</exception>
/// <param name="taskId"></param>
/// <returns>HumanTaskEntry</returns>
HumanTaskEntry GetTask1(string taskId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this as GetTask

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed

/// <exception cref="ApiException">Thrown when fails to make API call</exception>
/// <param name="_100"></param>
/// <returns>Task of Dictionary&lt;string, Object&gt;</returns>
System.Threading.Tasks.Task<Dictionary<string, Object>> BackPopulateFullTextIndexAsync(int? _100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@v1r3n v1r3n merged commit d214c4b into conductor-sdk:main Feb 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants