-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Human Task Resource API #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments with method names and internal methods that we should not expose in the sdk.
/// <exception cref="ApiException">Thrown when fails to make API call</exception> | ||
/// <param name="_100"></param> | ||
/// <returns>Dictionary<string, Object></returns> | ||
Dictionary<string, Object> BackPopulateFullTextIndex(int? _100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this API -- this is only for some maintenance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
/// <exception cref="ApiException">Thrown when fails to make API call</exception> | ||
/// <param name="taskId"></param> | ||
/// <returns>HumanTaskEntry</returns> | ||
HumanTaskEntry GetTask1(string taskId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this as GetTask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed
/// <exception cref="ApiException">Thrown when fails to make API call</exception> | ||
/// <param name="_100"></param> | ||
/// <returns>Task of Dictionary<string, Object></returns> | ||
System.Threading.Tasks.Task<Dictionary<string, Object>> BackPopulateFullTextIndexAsync(int? _100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
Changes to address the following