[New] Token Refresh Logic #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manan164
reviewed
Feb 22, 2024
manan164
reviewed
Feb 22, 2024
manan164
requested changes
Feb 23, 2024
Conductor/Client/ApiClient.cs
Outdated
| } | ||
| else | ||
| isTokenRefreshed = false; | ||
| } while (isTokenRefreshed); |
There was a problem hiding this comment.
- Why do we have to refresh the token in an infinite loop here? Given server can/ can not be reachable?
- Please write tests for the scenario covering 4xx response and with refreshToken() things will work.
manan164
reviewed
Feb 23, 2024
v1r3n
approved these changes
Feb 23, 2024
manan164
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to address