[RE-361] add datetime operator #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mibarrera01
reviewed
Jan 10, 2024
parser/datetime_operation.go
Outdated
| } | ||
|
|
||
| func (o *DateTimeOperation) get(left Operand, right Operand) (time.Time, time.Time, error) { | ||
| if left == nil { |
There was a problem hiding this comment.
esta linea o no es necesaria y/o se puede mover al metodo getTime
mibarrera01
reviewed
Jan 10, 2024
parser/datetime_operation.go
Outdated
| NullOperation | ||
| } | ||
|
|
||
| func (o *DateTimeOperation) getTime(operand Operand) (time.Time, error) { |
There was a problem hiding this comment.
opinion: dejando lo metodos visibles al inicio el package queda mas legible para el uso
mibarrera01
reviewed
Jan 10, 2024
| @@ -1643,7 +1677,7 @@ func (p *JsonQueryParser) Value() (localctx IValueContext) { | |||
| p.EnterRule(localctx, 6, JsonQueryParserRULE_value) | |||
| var _la int | |||
|
|
|||
| p.SetState(95) | |||
| p.SetState(96) | |||
There was a problem hiding this comment.
estos números de estado que son o como fucionan y si podemos hace una forma para no tener que cambiarlos con otro cambio, por ejemplo usando constantes.
There was a problem hiding this comment.
Ese codigo es autogenerado. No se cambia a mano.
mibarrera01
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.