Skip to content

Commit

Permalink
ci: update actions/download-artifact steps to v4
Browse files Browse the repository at this point in the history
Update actions/download-artifact steps in code-coverage-deploy to v4.
This requires uploaded artifacts to use actions/upload-artifact v4;
therefore, this has also been updated. This fixes CI failures for
code-coverage-deploy.

Github deprecated actions/download-artifact@v2 [1], making it cause
automatic failures on workflows that use it. This causes our code
coverage deploy jobs to fail [2].

1: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
2: https://github.com/conjure-cp/conjure-oxide/actions/runs/11134871648/job/30943894187
  • Loading branch information
niklasdewally committed Oct 2, 2024
1 parent 28ad1f1 commit 3f7f572
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/code-coverage-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ jobs:
})
- name: Download the previous lcov.info (historical) file
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with: |
name: code-coverage-${{ env.num }}-${{ env.previous_artifact_id }}
path: ./tools/code-coverage-diff/deploy-prev
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
echo "${{github.event.pull_request.number}}" > deploy/prnumber
- name: Archive code coverage results for deployment
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: code-coverage-${{ steps.sha.outputs.sha }}
path: deploy/**
Expand Down

0 comments on commit 3f7f572

Please sign in to comment.