fix some clippy warnings

conjure_oxide/build.rs

@@ -7,7 +7,7 @@ use walkdir::WalkDir;
 fn main() -> io::Result<()> {
  let out_dir = var("OUT_DIR").map_err(|e| io::Error::new(io::ErrorKind::Other, e))?; // wrapping in a std::io::Error to match main's error type
  let dest = Path::new(&out_dir).join("gen_tests.rs");
- let mut f = File::create(&dest)?;
+ let mut f = File::create(dest)?;
 
  let test_dir = "tests/integration";
 
@@ -45,7 +45,7 @@ fn write_test(file: &mut File, path: String, essence_files: Vec<String>) -> io::
  file,
  include_str!("./tests/gen_test_template"),
  // TODO: better sanitisation of paths to function names
- test_name = path.replace("./", "").replace("/", "_").replace("-", "_"),
+ test_name = path.replace("./", "").replace(['/', '-'], "_"),
  test_dir = path,
  essence_file = essence_files[0]
  )

conjure_oxide/src/parse.rs

@@ -124,7 +124,7 @@ fn parse_int_domain(v: &JsonValue) -> Result<Domain> {
  Ok(Domain::IntDomain(ranges))
 }
 
-fn parse_constraint(obj: &JsonValue) -> Result<()> {
+fn parse_constraint(_obj: &JsonValue) -> Result<()> {
  Ok(())
 }
 

conjure_oxide/src/solvers/minion.rs

@@ -1,5 +1,6 @@
 //! Solver interface to minion_rs.
 
+#[allow(unused_imports)]
 use anyhow::anyhow;
 
 use crate::ast::{
@@ -78,6 +79,7 @@ fn parse_var(
  let (low, high) = match range {
  ConjureRange::Bounded(x, y) => Ok((x.to_owned(), y.to_owned())),
  ConjureRange::Single(x) => Ok((x.to_owned(), x.to_owned())),
+ #[allow(unreachable_patterns)]
  x => Err(SolverError::NotSupported(SOLVER, format!("{:?}", x))),
  }?;
 

conjure_oxide/src/solvers/mod.rs

@@ -1,5 +1,5 @@
 mod error;
 pub mod minion;
 pub use error::*;
-mod solvers;
-pub use solvers::*;
+mod solver_list;
+pub use solver_list::*;

conjure_oxide/src/solvers/solvers.rs → conjure_oxide/src/solvers/solver_list.rs

@@ -1,11 +1,7 @@
-//! All supported solvers.
-
 use strum_macros::Display;
 use strum_macros::{EnumIter, EnumString};
 
 /// All supported solvers.
-///
-/// This enum implements, Display and Iter, so can be used as a string, or iterated over.
 #[derive(Debug, EnumString, EnumIter, Display)]
 pub enum Solver {
  Minion,

solvers/chuffed/src/lib.rs

@@ -1,7 +1,5 @@
 pub mod bindings {
- #![allow(non_upper_case_globals)]
- #![allow(non_camel_case_types)]
- #![allow(non_snake_case)]
+ #![allow(warnings)]
  include!(concat!(env!("OUT_DIR"), "/chuffed_bindings.rs"));
 }