-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add essence-feature-usage-stats tool #31
Conversation
.gitignore
Outdated
@@ -1,3 +1,10 @@ | |||
target | |||
|
|||
solvers/**/vendor/build | |||
tools/essence-feature-usage-stats/.venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.venv
pycache
.idea
hi @gskorokhod - let me know when you add the github action please. |
…stats code, and reformat .gitignore
Merge incoming changes from conjure-oxide
Georgii and I were discussing how to put stuff to gh pages yesterday (primarily the limitations of uploading artifacts through actions vs hosting the entire To clarify, are we hosting pages from its own branch, or from the |
A separate branch. I had sent Georgii an example from another repository where we used a GitHub action to deploy to gh-pages on a branch. I can find this again if he doesn't have it. |
@ozgurakgun I've finished setting up the action - I think it is ready to review? |
Also made columns hideable, made it possible to require/exclude specific keywords, and made the table look slightly nicer |
@@ -0,0 +1,11 @@ | |||
ESSENCE_DIR=/home/mayday/Coding/VIP/EssenceCatalog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these local paths still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the whole .env file is just for local testing. All the necessary env vars are in the GitHub Action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove them from the repo then? As they are, they won't work on anybody else's computer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! I have removed the file, just waiting for the CI to complete and the commit will appear here
@@ -0,0 +1,19 @@ | |||
black==23.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should ask dependabot to monitor these as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of minor comments, almost there!
Removed the .env and updated dependabot.yml file (hopefully it should track the Python packages now?) |
@gskorokhod - happy for me to merge this? |
Yes, I think it’s done! |
No description provided.