Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add essence-feature-usage-stats tool #31

Merged
merged 61 commits into from
Nov 4, 2023
Merged

Conversation

gskorokhod
Copy link
Contributor

No description provided.

.gitignore Outdated
@@ -1,3 +1,10 @@
target

solvers/**/vendor/build
tools/essence-feature-usage-stats/.venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.venv
pycache
.idea

@ozgurakgun
Copy link
Contributor

hi @gskorokhod - let me know when you add the github action please.

@niklasdewally
Copy link
Contributor

niklasdewally commented Nov 2, 2023

I suspect we don't need the generated html in this branch, just on the gh-pages branch (after deployment).

Georgii and I were discussing how to put stuff to gh pages yesterday (primarily the limitations of uploading artifacts through actions vs hosting the entire doc folder)

To clarify, are we hosting pages from its own branch, or from the doc/ folder. (I know GH supports both?)

@ozgurakgun
Copy link
Contributor

A separate branch. I had sent Georgii an example from another repository where we used a GitHub action to deploy to gh-pages on a branch. I can find this again if he doesn't have it.

@ozgurakgun
Copy link
Contributor

Found it: https://github.com/conjure-cp/task-allocation-demo/blob/14b930ff29e6b25724df01e1cc47a1d8ead04d57/.github/workflows/deploy.yml

@gskorokhod
Copy link
Contributor Author

@ozgurakgun I've finished setting up the action - I think it is ready to review?

@gskorokhod
Copy link
Contributor Author

Also made columns hideable, made it possible to require/exclude specific keywords, and made the table look slightly nicer

@@ -0,0 +1,11 @@
ESSENCE_DIR=/home/mayday/Coding/VIP/EssenceCatalog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these local paths still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the whole .env file is just for local testing. All the necessary env vars are in the GitHub Action

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove them from the repo then? As they are, they won't work on anybody else's computer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! I have removed the file, just waiting for the CI to complete and the commit will appear here

@@ -0,0 +1,19 @@
black==23.10.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should ask dependabot to monitor these as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@ozgurakgun ozgurakgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor comments, almost there!

@gskorokhod
Copy link
Contributor Author

Removed the .env and updated dependabot.yml file (hopefully it should track the Python packages now?)

@ozgurakgun
Copy link
Contributor

@gskorokhod - happy for me to merge this?

@gskorokhod
Copy link
Contributor Author

@gskorokhod - happy for me to merge this?

Yes, I think it’s done!

@ozgurakgun ozgurakgun merged commit 9280d47 into conjure-cp:main Nov 4, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants