Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Coverage CI #33

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Conversation

niklasdewally
Copy link
Contributor

@niklasdewally niklasdewally commented Nov 1, 2023

This PR adds a Github action to generate documentation coverage reports.
This is currently will just be for informational purposes, and is viewable in the CI job summary.

Would appreciate this to be squash merged when done.

@niklasdewally
Copy link
Contributor Author

niklasdewally commented Nov 1, 2023

Seems like the minion coverage report is building minion, so I better fix caching

Or maybe GitHub mobile is just showing ci wierdly. .

@niklasdewally
Copy link
Contributor Author

niklasdewally commented Nov 1, 2023

  • summary doesn't show on mobile - use tee to also print this to the job logs

@niklasdewally
Copy link
Contributor Author

@ozgurakgun i think this is good to go.

As opposed to the tests which run only on change of their corresponding crates, I think having coverage reports of all crates at all times is helpful, so that you can see the entire project's coverage at a glance by just looking at the latest commits' CI.

@niklasdewally
Copy link
Contributor Author

Caching definitely works :)

@ozgurakgun ozgurakgun merged commit 9acfd71 into conjure-cp:main Nov 2, 2023
4 checks passed
gskorokhod added a commit to gskorokhod/conjure-oxide that referenced this pull request Nov 2, 2023
@niklasdewally niklasdewally deleted the nd60/docs branch November 2, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants