Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ast): inconsistent Display implementations for variables #442

Merged
merged 1 commit into from
Nov 12, 2024

Commits on Nov 12, 2024

  1. fix(ast): inconsistent Display implementations for variables

    Change display implementations of Name, Factor, and Expression so that
    variables are always printed the same way.
    
    Previously, each of these implemented the printing of references
    themselves in different ways. For example, Name display used
    `MachineName(x)`, and Expressions `__x`.
    
    Now, variable display is only defined in `Name`. Instead of directly
    displaying references for `FactorE(Factor::Reference(...))` in
    Expression's display implementation, this instead calls display for
    `Factor`. In turn, `Factor` calls display for `Name` and `Literal`
    instead of implementing this itself.
    niklasdewally committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    665fdf2 View commit details
    Browse the repository at this point in the history