Minion: Use minion's build system not build.rs to build libminion, and CI tweaks #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1
Chris Jefferson has added support for building Minion as a library through its own build system: minion/minion#6.
This PR removes the code in build.rs that builds the libminion.a library, and instead calls minion's build system to do this for us.
I have also implemented CI caching as per #4.
The primary issue was the time needed to build minion. Therefore, minion's build directory is cached so that
make
can do proper incremental builds.Also,
build.rs
should now not run at all unless it or vendor code changes.