-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tools/essence-feature-usage-stats #51
Conversation
Pull changes from main repo
TODO document changes and look at ways to optimize it
@gskorokhod merged main one more time to bring in the new github actions changes, will stop messing up your PR now :) |
Merge main conjure-oxide repo
Good afternoon! I have fixed the sorting issues by switching to the DataTables plugin instead of my own sorting code, and added a link to download data as a CSV file. There is no Python lint errors and I've documented the new env variables in the project's README so should be ready to merge! |
@ozgurakgun I'm marking this as ready for review! |
This is not related to your changes, dw. Ping: @ozgurakgun Workflows don't get write access on PRs for security.
I would remove PR from the above in the CI file. Alternatively, if you want this to run in PRs successfully, you can use a workflow_run rule to do this. In short, workflow A runs in the context of the PR, generates all the pages, and stores them as artifacts. See code-coverage / code-coverage-deploy for existing examples of how to do this. |
The above basically ensures that a malicious contributor does not edit CI in a PR, and that edited CI nukes the repo. |
We still want to build for PRs, but not push/deploy. An if statement to the deploy step should solve it? |
I will have a look! |
Added the if statement |
…n runs, and we don't want to clutter the repo)
exactly! |
@@ -12,9 +12,13 @@ on: | |||
env: | |||
ESSENCE_DIR: "./EssenceCatalog" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this still need to be in the ENV? did you do multiple repos yet in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Repos are specified in another variable (ESSENCE_FILE_REPOS I think?)
This is just the root directory for essence files, all repos will be cloned to its sub directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it not a bit confusing to have it set to EssenceCatalog, which is one of the repo names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, changed that
I'm rearranging my branches (making main an exact copy of the main in conjure-cp/conjure-oxide, and creating dev branches for every feature I'm working on), so I will have to close and re-open this PR from a different branch |
Done
This tool should be done and ready for review now!