Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace refactor #53

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Conversation

lixitrixi
Copy link
Contributor

No description provided.

@lixitrixi
Copy link
Contributor Author

Here I separate conjure_oxide into its own package within the workspace and clean up the package structure slightly.

@lixitrixi
Copy link
Contributor Author

Not sure where the parsers directory commit comes from... Probably accidentally added to my fork's main at some point.

I will also try to set conjure as the default package to run.

@niklasdewally
Copy link
Collaborator

niklasdewally commented Nov 8, 2023

Might need some CI path changes (feel free to move this to a separate issue)

  • gen_coverage_all.sh
  • codecoveage.yml (line 69)
  • doc-coverage.yml
  • oxide.yml

@niklasdewally
Copy link
Collaborator

(We could always do this after #32 is done)

@ozgurakgun
Copy link
Contributor

ok, this looks fine but I am slightly confused about the relationship between this and #32. is this ready to go? will 32 continue after this is merged?

@niklasdewally
Copy link
Collaborator

ok, this looks fine but I am slightly confused about the relationship between this and #32. is this ready to go? will 32 continue after this is merged?

It's unrelated. There's some ci refactoring to do here before merge

@niklasdewally
Copy link
Collaborator

(just minor path fixes, shouldn't take long.)

@niklasdewally
Copy link
Collaborator

Fixed the CI paths as said above in #54.

(it is based on this branch, so this one needs merging first)

@ozgurakgun
Copy link
Contributor

I can merge this and #54 is everyone is happy?

@ozgurakgun ozgurakgun merged commit c27cef3 into conjure-cp:main Nov 12, 2023
17 checks passed
@lixitrixi lixitrixi deleted the workspace-refactor branch November 13, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants