-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kissat bindings #7
Conversation
Also in this PR I've added build files generated by Minion and anything else to .gitignore, since it was an issue for me. |
by merging #6 I created a (trivial) merge conflict here, sorry! can you fix it please @lixitrixi? |
I've added a general import rule to Cargo.toml which imports all |
This should now be good to merge @ozgurakgun ! |
if running cargo build in the root directory tries to build minion, it should be working. |
not a big deal but I slightly prefer explicitly listing the solvers. |
I've pulled and made the change back to explicitly listing them, but I get this error when building:
|
|
Nooooo I was about to change it back to listing them |
Ooops, I thought you had already done that :) another PR? |
|
Here I the kissat-rs module as cargo dependencies. This will hopefully help with modularity and size, and if we need to add to the libraries this can be changed to use our fork.
Next up is working on CI and unit testing for our SAT solver bindings. I'll try to find a public source of test DIMACS files and set up automatically running them through the bindings.