Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with go 1.22 and 1.23 #946

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Test with go 1.22 and 1.23 #946

merged 1 commit into from
Nov 12, 2024

Conversation

jhump
Copy link
Member

@jhump jhump commented Nov 11, 2024

The minimum for this repo is now 1.22, not 1.21, due to upgrades in both grpc-go and quic-go. We usually support the past three versions of Go, instead of just past two. But this repo isn't a library for our users (some of which may use Go 1.21) and isn't a tool that our users need to build from source (possibly using Go 1.21). Instead, we provide release binaries that users should download if they are unable to build from source. So dropping 1.21 should be fine for this repo.

Much of the diff is due to a handful of new lint checks -- we had to update golangci-lint in order to support 1.23, and it includes several new checks, particularly one that wants string constants/literals used to query HTTP headers to use canonical case (it is more efficient -- not using canonical case forces the http.Header value to build a new canonicalized string before querying the underlying map).

Also, moving to 1.22 means the default loop-variable behavior no longer captures the address, so we no longer need to make a copy (and there's a linter that catches this, so they've all been updated).

Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>
@jhump jhump requested a review from smaye81 November 11, 2024 20:20
Copy link

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 11, 2024, 8:20 PM

@jhump jhump merged commit 0829909 into main Nov 12, 2024
10 checks passed
@jhump jhump deleted the jh/test-w-go1.23 branch November 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants