Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum for this repo is now 1.22, not 1.21, due to upgrades in both grpc-go and quic-go. We usually support the past three versions of Go, instead of just past two. But this repo isn't a library for our users (some of which may use Go 1.21) and isn't a tool that our users need to build from source (possibly using Go 1.21). Instead, we provide release binaries that users should download if they are unable to build from source. So dropping 1.21 should be fine for this repo.
Much of the diff is due to a handful of new lint checks -- we had to update golangci-lint in order to support 1.23, and it includes several new checks, particularly one that wants string constants/literals used to query HTTP headers to use canonical case (it is more efficient -- not using canonical case forces the
http.Header
value to build a new canonicalized string before querying the underlying map).Also, moving to 1.22 means the default loop-variable behavior no longer captures the address, so we no longer need to make a copy (and there's a linter that catches this, so they've all been updated).