V2: Introduce connect-query-core package #357
Conversation
|
I removed CI support for node 16 since it seems to have a bug with pnpm when running on CI fails due to what I suspect is a weird concurrency issue. I may reintroduce node 16 CI but since it was eol as of 09/2023, it shouldn't be a priority anyways. |
|
Any idea what it'll take to get this one released? Starting an app that uses Svelte, and I would really love to use the Query package with Svelte, but in the current state it does not work. |
@plunkettscott, we're currently working on support for protobuf-es v2 (see #389). We'll try to get this PR in the next release. |
paul-sachs
force-pushed
the
psachs/connect-query-core
branch
from
112c93c
to
349ce3d
Compare
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/connect-query-core
branch
2 times, most recently
from
0d1bd32
to
8a20cc3
Compare
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/connect-query-core
branch
from
8a20cc3
to
1344085
Compare
|
Rebased the branch against v2 so we can consider getting this into an rc. |
paul-sachs
changed the title
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: Paul Sachs <psachs@buf.build>
Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/connect-query-core
branch
from
136f56a
to
3897dc3
Compare
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/connect-query-core
branch
from
e4001d5
to
69baadc
Compare
Signed-off-by: Paul Sachs <psachs@buf.build>
There was a problem hiding this comment.
Can we delete packages/connect-query-core/proto?
npx turbo run test -F ./packages/connect-query-core will not re-generate code if packages/test-utils/proto/* changes. Need to fix this. Can probably change turbo.json / generate / dependsOn to ["generate", "^generate"].
I'm not a fan of importing TypeScript from packages. It can have very weird side-effects, for example the tsconfig.json in the package doesn't apply to the code in the package, except for the IDE 🙈
Removed unused protos and made sure generate is triggered on tests Signed-off-by: Paul Sachs <psachs@buf.build>
|
@timostamm All good points. Updated and pushed changes. |
|
As for publishing typescript, yeah it can be finicky. I figured for an internal package, it would be fine (since they all inherit the same tsconfig) but i migrated to publish js+dts anyways. I'm just hoping for the deno+jsr based future when all i need to do is write TS and it just works 🪄 |
TypeScript doesn't even use semver, but yes. At least the extra build step is not very distracting with something like turbo. |
A dedicated connect-query-core package makes it much easier to integrate non-react integrations.
The public API of
@connectrpc/connect-queryhasn't changed at all, all the same methods and types are exposed, we've just separated them into a distinct package that gets reexported from@connectrpc/connect-query.This change allows others to depend on connect-query without necessarily depending on react and react-query.
Partially addresses #324