support SwapRouter02 and update UniversalRouter addr #491
Triggered via pull request
September 10, 2023 14:02
charlesjhongc
Status
Success
Total duration
1m 32s
Artifacts
–
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
11 warnings
|
build (16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L15
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L16
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L24
Named parameters missing. MIN unnamed argumenst is 4
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L35
Function order is incorrect, internal view function can not go after private view function (line 27)
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L39
Function name must be in mixedCase
|
|
build (16.x):
contracts/abstracts/Multicall.sol#L12
Avoid to use low level calls
|
|
build (16.x):
contracts/abstracts/Multicall.sol#L22
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
build (16.x):
contracts/abstracts/Ownable.sol#L15
Function order is incorrect, event definition can not go after custom error definition (line 13)
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L16
Function order is incorrect, enum definition can not go after custom error definition (line 14)
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L24
Immutable variables name are set to be in capitalized SNAKE_CASE
|