Chore: cleanup and upgrade codebase #540
alex0207sAnnotations
12 warnings
|
build (16.x)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build (16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L15
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L16
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L24
Named parameters missing. MIN unnamed argumenst is 4
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L35
Function order is incorrect, internal view function can not go after private view function (line 27)
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L39
Function name must be in mixedCase
|
|
build (16.x):
contracts/abstracts/Ownable.sol#L15
Function order is incorrect, event definition can not go after custom error definition (line 13)
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L16
Function order is incorrect, enum definition can not go after custom error definition (line 14)
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L24
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L25
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L40
Avoid to use low level calls
|