gas optimization: leave one wei feature #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
108356037
reviewed
Dec 5, 2023
test/forkMainnet/GenericSwap.t.sol
Outdated
| @@ -156,16 +157,17 @@ contract GenericSwapTest is Test, Tokens, BalanceUtil, Permit2Helper, SigHelper | |||
| Snapshot memory makerMakerToken = BalanceSnapshot.take({ owner: address(mockStrategy), token: gsData.makerToken }); | |||
|
|
|||
| uint256 actualOutput = 900; | |||
| uint256 realChangedInGas = actualOutput - 1; | |||
There was a problem hiding this comment.
It's a typo, it should be GS here.
test/forkMainnet/GenericSwap.t.sol
Outdated
| gsData.takerToken, | ||
| gsData.takerTokenAmount, | ||
| gsData.makerToken, | ||
| gsData.makerTokenAmount - 1 |
There was a problem hiding this comment.
I think we can have expectedOut = gsData.makerTokenAmount - 1 for these assertion.
There was a problem hiding this comment.
Good idea, but maybe call it realChangedInGS for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For gas optimization purposes, we retain 1 wei of each token in our contract(GS and SOS). This will impact the initial swap of every token, as 1 wei will be left in our contract.
GenericSwap.solSmartOrderStrategy.sol