-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v6.0.1 #310
Merged
Merged
Fix v6.0.1 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108356037
reviewed
May 1, 2024
This does not feel like a "fix". This is changing how we treat WETH as maker token:
|
Please add a readme or a natspec/comment for how we handle different maker tokens, to help others better understand how it works.
|
NIC619
reviewed
May 2, 2024
NIC619
reviewed
May 3, 2024
NIC619
previously approved these changes
May 6, 2024
alex0207s
commented
May 21, 2024
NIC619
reviewed
May 21, 2024
…and-add-natspec Chore/increase test coverage and add natspec
…ebase Chore: cleanup and upgrade codebase
NIC619
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salt
) toSwap
event in GenericSwap contractuniAgent.sol
contractWhy do we need to adjust the handling logic for makerToken as ETH in the RFQ contract?
Prior to this PR, when makerToken is ETH, RFQ directly unwraps WETH into ETH. This isn't ideal, especially when RFQ is only a segment of the entire swap path. If RFQ unwraps WETH into ETH directly, it requires the subsequent swapping process to wrap ETH back into WETH, incurring additional steps and costs.
With this PR, we don't unwrap WETH directly. WETH is only unwrapped to ETH when the makerToken is ETH. This could avoid additional steps or costs associated with handling WETH.
Why do we need to adjust the calculation method for a input token ratio?
Prior to this PR, the ratio value was expressed in ten-thousandths (0.01%), which was not precise enough for some specific protocols(e.g. dsspsm).
With this PR, the ratio is now determined by both the numerator and the denominator, allowing for greater flexibility and accuracy in expressing the ratio.
Why do we remove
uniAgent.sol
?Due to a backend integration issue, the current version of uniAgent.sol is not sufficient to replace GenericSwap.sol and SmartOrderStrategy.sol when the swap only occurs in the Uniswap pool.