Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify evm version: Shanghai #321

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

alex0207s
Copy link
Contributor

This PR sets the default EVM version (Paris) to Shanghai. The reason for this change is that all the multi-chain networks supported by Tokenlon have already adopted the Shanghai upgrade.

Copy link

Changes to gas cost

Generated at commit: f7377bf9ff29e1d4efccce957235c92a92b55df5, compared to commit: 6cddd3c93bf4855989dfddeb5c7faac539b419df

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
AllowanceTarget spendFromUserTo
unpause
-19 ✅
-3 ✅
-0.04%
-0.01%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AllowanceTarget 604,945 (-8,509) pause
spendFromUserTo
unpause
23,420 (-2)
25,025 (-4)
23,421 (-2)
-0.01%
-0.02%
-0.01%
26,605 (-3)
51,245 (-19)
25,533 (-3)
-0.01%
-0.04%
-0.01%
27,667 (-4)
49,827 (-22)
25,533 (-3)
-0.01%
-0.04%
-0.01%
27,667 (-4)
91,576 (-30)
27,645 (-4)
-0.01%
-0.03%
-0.01%
4 (0)
8 (0)
2 (0)

Copy link

Changes to gas cost

Generated at commit: f7377bf9ff29e1d4efccce957235c92a92b55df5, compared to commit: 6cddd3c93bf4855989dfddeb5c7faac539b419df

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
LimitOrderSwap isOrderCanceled -3 ✅ -0.59%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
CoordinatedTaker 2,320,659 (-46,690) EIP712_DOMAIN_SEPARATOR
allowanceTarget
approveTokens
coordinator
limitOrderSwap
owner
permit2
setCoordinator
submitLimitOrderFill
weth
309 (-3)
271 (-1)
27,089 (-6)
394 (-1)
293 (-1)
413 (-2)
272 (-1)
23,740 (-3)
33,092 (-11)
294 (-1)
-0.96%
-0.37%
-0.02%
-0.25%
-0.34%
-0.48%
-0.37%
-0.01%
-0.03%
-0.34%
309 (-3)
271 (-1)
169,190 (-71)
394 (-1)
293 (-1)
413 (-2)
272 (-1)
25,907 (-3)
128,380 (-93)
294 (-1)
-0.96%
-0.37%
-0.04%
-0.25%
-0.34%
-0.48%
-0.37%
-0.01%
-0.07%
-0.34%
309 (-3)
271 (-1)
188,958 (-80)
394 (-1)
293 (-1)
413 (-2)
272 (-1)
23,939 (-3)
70,032 (-41)
294 (-1)
-0.96%
-0.37%
-0.04%
-0.25%
-0.34%
-0.48%
-0.37%
-0.01%
-0.06%
-0.34%
309 (-3)
271 (-1)
188,958 (-80)
394 (-1)
293 (-1)
413 (-2)
272 (-1)
30,043 (-3)
256,485 (-182)
294 (-1)
-0.96%
-0.37%
-0.04%
-0.25%
-0.34%
-0.48%
-0.37%
-0.01%
-0.07%
-0.34%
2 (0)
1 (0)
15 (0)
2 (0)
1 (0)
1 (0)
1 (0)
3 (0)
7 (0)
1 (0)
LimitOrderSwap 2,680,115 (-50,525) allowanceTarget
cancelOrder
feeCollector
fillLimitOrder
fillLimitOrderFullOrKill
fillLimitOrderGroup
isOrderCanceled
orderHashToMakerTokenFilledAmount
owner
permit2
setFeeCollector
weth
305 (-1)
29,254 (-3)
403 (-1)
36,084 (-10)
48,264 (-40)
31,159 (-9)
504 (-3)
470 (-3)
403 (-2)
284 (-1)
23,790 (-3)
283 (-1)
-0.33%
-0.01%
-0.25%
-0.03%
-0.08%
-0.03%
-0.59%
-0.63%
-0.49%
-0.35%
-0.01%
-0.35%
305 (-1)
40,664 (-10)
403 (-1)
1,179,402 (-71)
103,992 (-64)
174,604 (-135)
504 (-3)
470 (-3)
403 (-2)
284 (-1)
25,961 (-3)
283 (-1)
-0.33%
-0.02%
-0.25%
-0.01%
-0.06%
-0.08%
-0.59%
-0.63%
-0.49%
-0.35%
-0.01%
-0.35%
305 (-1)
33,850 (-12)
403 (-1)
161,668 (-102)
48,264 (-40)
198,117 (-149)
504 (-3)
470 (-3)
403 (-2)
284 (-1)
23,995 (-3)
283 (-1)
-0.33%
-0.04%
-0.25%
-0.06%
-0.08%
-0.08%
-0.59%
-0.63%
-0.49%
-0.35%
-0.01%
-0.35%
305 (-1)
52,753 (-14)
403 (-1)
29,534,877 (-3)
215,449 (-113)
291,749 (-226)
504 (-3)
470 (-3)
403 (-2)
284 (-1)
30,099 (-3)
283 (-1)
-0.33%
-0.03%
-0.25%
-0.00%
-0.05%
-0.08%
-0.59%
-0.63%
-0.49%
-0.35%
-0.01%
-0.35%
8 (0)
7 (0)
9 (0)
28 (0)
3 (0)
9 (0)
1 (0)
1 (0)
8 (0)
8 (0)
3 (0)
8 (0)
RFQ 2,419,951 (-45,470) allowanceTarget
cancelRFQOffer
feeCollector
fillRFQ
fillRFQWithSig
owner
permit2
setFeeCollector
weth
260 (-1)
23,993 (-3)
381 (-1)
31,809 (-13)
33,865 (-17)
403 (-2)
284 (-1)
23,790 (-3)
261 (-1)
-0.38%
-0.01%
-0.26%
-0.04%
-0.05%
-0.49%
-0.35%
-0.01%
-0.38%
260 (-1)
37,914 (-9)
381 (-1)
131,093 (-78)
113,364 (-78)
403 (-2)
284 (-1)
25,961 (-3)
261 (-1)
-0.38%
-0.02%
-0.26%
-0.06%
-0.07%
-0.49%
-0.35%
-0.01%
-0.38%
260 (-1)
38,908 (-10)
381 (-1)
147,882 (-94)
77,637 (-73)
403 (-2)
284 (-1)
23,995 (-3)
261 (-1)
-0.38%
-0.03%
-0.26%
-0.06%
-0.09%
-0.49%
-0.35%
-0.01%
-0.38%
260 (-1)
49,848 (-11)
381 (-1)
238,797 (-111)
228,592 (-142)
403 (-2)
284 (-1)
30,099 (-3)
261 (-1)
-0.38%
-0.02%
-0.26%
-0.05%
-0.06%
-0.49%
-0.35%
-0.01%
-0.38%
1 (0)
4 (0)
2 (0)
24 (0)
3 (0)
1 (0)
1 (0)
3 (0)
1 (0)
GenericSwap 1,721,472 (-35,050) allowanceTarget
executeSwap
executeSwapWithSig
permit2
260 (-1)
32,313 (-9)
39,507 (-21)
261 (-1)
-0.38%
-0.03%
-0.05%
-0.38%
260 (-1)
117,618 (-52)
168,354 (-75)
261 (-1)
-0.38%
-0.04%
-0.04%
-0.38%
260 (-1)
115,311 (-63)
175,076 (-79)
261 (-1)
-0.38%
-0.05%
-0.05%
-0.38%
260 (-1)
251,909 (-103)
283,756 (-124)
261 (-1)
-0.38%
-0.04%
-0.04%
-0.38%
1 (0)
12 (0)
4 (0)
1 (0)
SmartOrderStrategy 1,199,403 (-27,288) approveTokens
executeStrategy
56,262 (-20)
23,226 (-8)
-0.04%
-0.03%
185,004 (-80)
123,637 (-46)
-0.04%
-0.04%
268,687 (-119)
90,770 (-26)
-0.04%
-0.03%
268,687 (-119)
610,173 (-47)
-0.04%
-0.01%
33 (0)
18 (0)

@alex0207s alex0207s requested a review from NIC619 July 24, 2024 07:33
@alex0207s alex0207s merged commit e16c312 into master Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants