Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BCSS Dataset #156

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Add BCSS Dataset #156

merged 9 commits into from
Oct 19, 2023

Conversation

anwai98
Copy link
Collaborator

@anwai98 anwai98 commented Oct 17, 2023

(WIP) Implementation for the Breast Cancer Semantic Segmentation dataset.
(TODOs):

  • need to fix data download using gdown (download limit for folders is upto 50 files, need to take care of that) warning raised
  • need to take care of the semantic instances (there are more than one tissue region segmentations available, need to add an optional argument to request for all instances / some instances, as desired)

@anwai98 anwai98 marked this pull request as ready for review October 18, 2023 13:31
@anwai98
Copy link
Collaborator Author

anwai98 commented Oct 18, 2023

@constantinpape This one's ready to go. Let me know how it looks.

torch_em/data/datasets/bcss.py Outdated Show resolved Hide resolved
torch_em/data/datasets/bcss.py Outdated Show resolved Hide resolved
torch_em/data/datasets/bcss.py Outdated Show resolved Hide resolved
self,
labels: np.ndarray
) -> np.ndarray:
"""Returns the transformed labels (use-case for SAM)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the same use-case we should use connected components (skimage.measure.label) instead of just relabeling.
This way we can separate disconnected pieces, and have an instance segmentation, which will be better for SAM.
(Since this is just the sample script it's not important to update this here, but please keep it in mind for SAM.)

@constantinpape constantinpape merged commit b8d9cd9 into constantinpape:main Oct 19, 2023
0 of 2 checks passed
@anwai98 anwai98 deleted the bcss branch October 19, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants