Skip to content

Commit

Permalink
Address spelling/grammar errors
Browse files Browse the repository at this point in the history
  • Loading branch information
bswartz committed Jun 5, 2021
1 parent 3f7aeca commit 7574213
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 17 deletions.
10 changes: 5 additions & 5 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ message ControllerUnpublishVolumeRequest {
// section on how to use this field.
map<string, string> secrets = 3 [(csi_secret) = true];

// Indicates SP MUST make the volume inacessible to the node or nodes
// Indicates SP MUST make the volume inaccessible to the node or nodes
// it is being unpublished from. Any attempt to read or write data
// to a volume from a node that has been fenced MUST NOT succeed,
// even if the volume remains staged and/or published on the node.
Expand Down Expand Up @@ -1505,10 +1505,10 @@ message NodeServiceCapability {
// Note that, for alpha, `VolumeCondition` is intended to be
// informative for humans only, not for automation.
VOLUME_CONDITION = 4 [(alpha_enum_value) = true];
// Indicates that the node supports the NodeUnpublishVolume.force
// field. Also indicates that the node supports the
// NodeUnstageVolume.force field if it also has the
// STAGE_UNSTAGE_VOLUME capability.
// Indicates that the Node Plugin supports the
// NodeUnpublishVolume.force field. Also indicates that the
// Node Plugin supports the NodeUnstageVolume.force field if
// it also has the STAGE_UNSTAGE_VOLUME capability.
FORCE_UNPUBLISH = 5 [(alpha_enum_value) = true];
}

Expand Down
6 changes: 3 additions & 3 deletions lib/go/csi/csi.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -1338,7 +1338,7 @@ message ControllerUnpublishVolumeRequest {
// section on how to use this field.
map<string, string> secrets = 3 [(csi_secret) = true];
// Indicates SP MUST make the volume inacessible to the node or nodes
// Indicates SP MUST make the volume inaccessible to the node or nodes
// it is being unpublished from. Any attempt to read or write data
// to a volume from a node that has been fenced MUST NOT succeed,
// even if the volume remains staged and/or published on the node.
Expand Down Expand Up @@ -2195,8 +2195,8 @@ If the corresponding Controller Plugin has `PUBLISH_UNPUBLISH_VOLUME` controller
The CO MUST guarantee that this RPC is called after all `NodeUnpublishVolume` have been called and returned success for the given volume on the given node.

If the Node Plugin has the `FORCE_UNPUBLISH` capability, the CO MAY specify `force` as `true` in which case the Node Plugin MUST support unstaging volumes even when access has been revoked with `ControllerUnpublishVolume`.
Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even it if means losing data.
It is essential that after a successful call to `NodeUnstageVolume` that there be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it were to be subsequently re-staged to that node.
Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even if it means losing data.
It is essential that after a successful call to `NodeUnstageVolume` that there will be no buffered data on the node related to the volume which might result in unintentional modification of the volume if it was to be subsequently re-staged to that node.

The Plugin SHALL assume that this RPC will be executed on the node where the volume is being used.

Expand Down Expand Up @@ -2368,8 +2368,8 @@ If the corresponding Controller Plugin has `PUBLISH_UNPUBLISH_VOLUME` controller
The Plugin SHALL assume that this RPC will be executed on the node where the volume is being used.

If the Node Plugin has the `FORCE_UNPUBLISH` capability, the CO MAY specify `force` as `true` in which case the Node Plugin MUST support unpublishing volumes even when access has been revoked with `ControllerUnpublishVolume`.
Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even it if means losing data.
It is essential that after a successful call to `NodeUnpublishVolume` that there be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it were to be subsequently re-published to that node.
Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even if it means losing data.
It is essential that after a successful call to `NodeUnpublishVolume` that there will be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it was to be subsequently re-published to that node.

This RPC is typically called by the CO when the workload using the volume is being moved to a different node, or all the workload using the volume on a node has finished.

Expand Down Expand Up @@ -2553,10 +2553,10 @@ message NodeServiceCapability {
// Note that, for alpha, `VolumeCondition` is intended to be
// informative for humans only, not for automation.
VOLUME_CONDITION = 4 [(alpha_enum_value) = true];
// Indicates that the node supports the NodeUnpublishVolume.force
// field. Also indicates that the node supports the
// NodeUnstageVolume.force field if it also has the
// STAGE_UNSTAGE_VOLUME capability.
// Indicates that the Node Plugin supports the
// NodeUnpublishVolume.force field. Also indicates that the
// Node Plugin supports the NodeUnstageVolume.force field if
// it also has the STAGE_UNSTAGE_VOLUME capability.
FORCE_UNPUBLISH = 5 [(alpha_enum_value) = true];
}
Expand Down

0 comments on commit 7574213

Please sign in to comment.