Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cachi2: update postbuild plugins #2127

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Nov 6, 2024

Updating post build plugins to support cachi2 task

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Update add_image_content_manifest to process cachi2 results.

ICM must be generated from cachi2 SBOM in this case.

Signed-off-by: Martin Basti <mbasti@redhat.com>
Update generate_sbom to process cachi2 results.
SBOM must be combined from cachi2 SBOM stored in build_dir
in this case.

Signed-off-by: Martin Basti <mbasti@redhat.com>
Update koji_import to process cachi2 results.

Signed-off-by: Martin Basti <mbasti@redhat.com>
@MartinBasti
Copy link
Contributor Author

rebased to remove DO NOT MERGE commit

@MartinBasti MartinBasti merged commit 0faf9eb into containerbuildsystem:feature_cachi2 Nov 12, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants