Support both cachi2 and cachito #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MartinBasti
force-pushed
the
support-both-cachi2-and-cachito
branch
2 times, most recently
from
80680a9
to
dcf6ab4
Compare
MartinBasti
force-pushed
the
feature_cachi2
branch
from
0faf9eb
to
6d08687
Compare
MartinBasti
force-pushed
the
support-both-cachi2-and-cachito
branch
from
ebe6512
to
06d20b1
Compare
MartinBasti
force-pushed
the
support-both-cachi2-and-cachito
branch
from
06d20b1
to
bf3da2a
Compare
rcerven
approved these changes
Nov 22, 2024
ben-alkov
approved these changes
Nov 22, 2024
| @@ -462,6 +462,7 @@ def __init__( | |||
| plugin_files: Optional[List[str]] = None, | |||
| keep_plugins_running: bool = False, | |||
| platforms_result: Optional[str] = None, | |||
| remote_sources_version_result: Optional[str] = None, | |||
tests/tasks/test_plugin_based.py
Outdated
| @@ -208,7 +208,8 @@ def test_ensure_workflow_data_is_saved_init_task( | |||
| pipeline_run_name='test-pipeline-run', | |||
| user_params={}, | |||
| task_result='results', | |||
| platforms_result='platforms_result') | |||
| platforms_result='platforms_result', | |||
| remote_sources_version_result='version_result') | |||
User/admin may specify which version of remote sources should be used (or used by default): - 1: Cachito (current default) - 2: Cachi2 Build pipeline will then use the right task based on condition using result from the init task. STONEBLD-2591 Signed-off-by: Martin Basti <mbasti@redhat.com>
Fixing issues reported by shellcheck via checkton. Signed-off-by: Martin Basti <mbasti@redhat.com>
Remove before merging into main Signed-off-by: Martin Basti <mbasti@redhat.com>
MartinBasti
force-pushed
the
support-both-cachi2-and-cachito
branch
2 times, most recently
from
d329aea
to
341ef22
Compare
MartinBasti
merged commit 2b7138a
into
containerbuildsystem:feature_cachi2
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section