Cachi2 empty pkg managers #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MartinBasti
force-pushed
the
cachi2-empty-pkg-managers
branch
from
4888bab
to
bae8002
Compare
chmeliik
reviewed
Nov 27, 2024
MartinBasti
force-pushed
the
cachi2-empty-pkg-managers
branch
from
bae8002
to
7a39f52
Compare
|
updated, reworded |
chmeliik
approved these changes
Nov 27, 2024
mkosiarc
approved these changes
Nov 28, 2024
When users specify empty list as pkg_managers, only cloning should be done. In this case usage of cachi2 must be skipped and required files like env.json and bom.json must be created by OSBS. Signed-off-by: Martin Basti <mbasti@redhat.com>
MartinBasti
force-pushed
the
cachi2-empty-pkg-managers
branch
from
7a39f52
to
26578c0
Compare
|
Rebased and removed |
MartinBasti
merged commit 7055df8
into
containerbuildsystem:feature_cachi2
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users specify empty list as pkg_managers, only cloning should be
done. In this case usage of cachi2 must be skipped and required files
like env.json and bom.json must be created by OSBS.
Maintainers will complete the following section